hi chris, working with open source often gives the satisfaction to put your own contribution to something great.
it takes time, and effort to cooperate with people all over the world, but in the end the results are worth. but here, i have unfortunately mislead you to a bug, which only showed to me because of my convulted widgets. turbogears, [01].* is using a widget engine, first tgwidgets, later tw. the tg controller was used to retrieve resources from this engine, with appropriate functions, and put them in a page's head through the py:for construct in the master template. as time went on, toscawidgets found a misterious way to inject the resources itself, thus relieving effort from all the frameworks using it, tg among them. to avoid injection duplicate, tw lets the client framework think there are no resources (while developers might see the appropriate warning). even if tw would have removed the retrieve_* methods, tg wouldn't suffer, since it checks for their existence with getattr. hence, later tg may even clean up this code fragment, when it would decide to only use tw. thus, in my **too late** opinion you don't have to change the tg retrievals. you may only remove them when breaking with tgwidgets. best regards and thanks for your help, alex On Thu, Oct 16, 2008 at 11:27, Christopher Arndt <[EMAIL PROTECTED]> wrote: > > alex bodnaru schrieb: >> thanks for the patch. >> >> you will be angry at me: > > Not at all. After all, TG1 is using deprecated code and this needs to be > fixed. > >> as i told you, removing the master reorganization lines didn't affect >> the rendering of the resources. >> well, these were running exactly on the input from retrieve_javascript >> and _css. hence, removing the >> patch i have applied to revive these did not hurt this rendering. >> hence, the patch i've asked you for >> was not needed either. i have retested with more standard tableform >> and tw.autocomplete, and everything >> went well. don't know how ;) . >> >> about your patch: it does apply but tg won't run afterwards. i have tg >> 1.1b1. will it be safe to checkout >> 1.1trunk to make the try? > > Yes, I said it wasn't tested and as usual, when something isn't tested, > it doesn't work. > > As you pointed out, with TW it isn't even needed for Tg to retrieve the > JS/CSS resources and inject them via special template variables, TW > takes care of this itself (though I am not 100% sure exactly how it does > this yet). > > So I adapted the patch, so that it just skips TW widgets in > controllers._process_output. If someone could review the patch, I would > be grateful! > > http://trac.turbogears.org/ticket/2010#comment:4 > >> i also feel sorry for the time you spent with the patch, >> though you were very helpful with explaining me what i need for non >> widget javascript, > > No worries. As I said, you pointed out a real flaw in the code. > > > Chris > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "TurboGears" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/turbogears?hl=en -~----------~----~----~----~------~----~------~--~---
