Author: jmarino
Date: Tue Feb 28 15:27:27 2006
New Revision: 381822

URL: http://svn.apache.org/viewcvs?rev=381822&view=rev
Log:
removal of FIXMEs

Modified:
    
incubator/tuscany/java/sca/container.java/src/main/java/org/apache/tuscany/container/java/builder/JavaComponentContextBuilder.java

Modified: 
incubator/tuscany/java/sca/container.java/src/main/java/org/apache/tuscany/container/java/builder/JavaComponentContextBuilder.java
URL: 
http://svn.apache.org/viewcvs/incubator/tuscany/java/sca/container.java/src/main/java/org/apache/tuscany/container/java/builder/JavaComponentContextBuilder.java?rev=381822&r1=381821&r2=381822&view=diff
==============================================================================
--- 
incubator/tuscany/java/sca/container.java/src/main/java/org/apache/tuscany/container/java/builder/JavaComponentContextBuilder.java
 (original)
+++ 
incubator/tuscany/java/sca/container.java/src/main/java/org/apache/tuscany/container/java/builder/JavaComponentContextBuilder.java
 Tue Feb 28 15:27:27 2006
@@ -151,7 +151,6 @@
                 EventInvoker initInvoker = null;
                 boolean eagerInit = false;
                 EventInvoker destroyInvoker = null;
-                // FIXME this should be run as part of the LCM load
                 for (Field field : fields) {
                     ComponentName compName = 
field.getAnnotation(ComponentName.class);
                     if (compName != null) {
@@ -165,7 +164,6 @@
                     }
                 }
                 for (Method method : methods) {
-                    // FIXME Java5
                     Init init = method.getAnnotation(Init.class);
                     if (init != null && initInvoker == null) {
                         initInvoker = new MethodEventInvoker(method);
@@ -192,7 +190,6 @@
                 }
                 // handle properties
                 List<ConfiguredProperty> configuredProperties = 
component.getConfiguredProperties();
-                // FIXME should return empty properties - does it?
                 if (configuredProperties != null) {
                     for (ConfiguredProperty property : configuredProperties) {
                         Injector injector = createPropertyInjector(property, 
fields, methods);
@@ -215,7 +212,8 @@
                         iConfigMap.put(method, iConfig);
                     }
                     QualifiedName qName = new 
QualifiedName(component.getName() + "/" + service.getName());
-                    ProxyConfiguration pConfiguration = new 
ProxyConfiguration(qName, iConfigMap, 
serviceContract.getInterface().getClassLoader(), messageFactory);
+                    ProxyConfiguration pConfiguration = new 
ProxyConfiguration(qName, iConfigMap, serviceContract.getInterface()
+                            .getClassLoader(), messageFactory);
                     
proxyFactory.setBusinessInterface(serviceContract.getInterface());
                     proxyFactory.setProxyConfiguration(pConfiguration);
                     config.addTargetProxyFactory(service.getName(), 
proxyFactory);
@@ -289,7 +287,6 @@
             throws NoAccessorException {
         Object value = property.getValue();
         String propName = property.getProperty().getName();
-        // @FIXME is this how to get property type of object
         Class type = value.getClass();
 
         // There is no efficient way to do this
@@ -302,7 +299,6 @@
             }
         }
         Injector injector = null;
-        // FIXME support types other than String
         if (value instanceof DataObject) {
             if (field != null) {
                 injector = new FieldInjector(field, new 
SDOObjectFactory((DataObject) value));


Reply via email to