Author: rfeng
Date: Sat Sep 23 15:14:27 2006
New Revision: 449318
URL: http://svn.apache.org/viewvc?view=rev&rev=449318
Log:
Fix PMD violations
Modified:
incubator/tuscany/java/sca/services/databinding/databinding-framework/src/main/java/org/apache/tuscany/databinding/util/XSDDataTypeConverter.java
Modified:
incubator/tuscany/java/sca/services/databinding/databinding-framework/src/main/java/org/apache/tuscany/databinding/util/XSDDataTypeConverter.java
URL:
http://svn.apache.org/viewvc/incubator/tuscany/java/sca/services/databinding/databinding-framework/src/main/java/org/apache/tuscany/databinding/util/XSDDataTypeConverter.java?view=diff&rev=449318&r1=449317&r2=449318
==============================================================================
---
incubator/tuscany/java/sca/services/databinding/databinding-framework/src/main/java/org/apache/tuscany/databinding/util/XSDDataTypeConverter.java
(original)
+++
incubator/tuscany/java/sca/services/databinding/databinding-framework/src/main/java/org/apache/tuscany/databinding/util/XSDDataTypeConverter.java
Sat Sep 23 15:14:27 2006
@@ -392,8 +392,9 @@
this(true, true);
}
- private int parseInt(String pString, int pOffset, StringBuffer
pDigits) {
+ private int parseInt(String pString, int offset, StringBuffer pDigits)
{
int length = pString.length();
+ int pOffset = offset;
pDigits.setLength(0);
while (pOffset < length) {
char c = pString.charAt(pOffset);
@@ -409,10 +410,10 @@
public Object parseObject(String pString, ParsePosition
pParsePosition) {
if (pString == null) {
- throw new NullPointerException("The String argument must not
be null.");
+ throw new IllegalArgumentException("The String argument must
not be null.");
}
if (pParsePosition == null) {
- throw new NullPointerException("The ParsePosition argument
must not be null.");
+ throw new IllegalArgumentException("The ParsePosition argument
must not be null.");
}
int offset = pParsePosition.getIndex();
int length = pString.length();
@@ -575,13 +576,13 @@
public StringBuffer format(Object pCalendar, StringBuffer pBuffer,
FieldPosition pPos) {
if (pCalendar == null) {
- throw new NullPointerException("The Calendar argument must not
be null.");
+ throw new IllegalArgumentException("The Calendar argument must
not be null.");
}
if (pBuffer == null) {
- throw new NullPointerException("The StringBuffer argument must
not be null.");
+ throw new IllegalArgumentException("The StringBuffer argument
must not be null.");
}
if (pPos == null) {
- throw new NullPointerException("The FieldPosition argument
must not be null.");
+ throw new IllegalArgumentException("The FieldPosition argument
must not be null.");
}
Calendar cal = (Calendar) pCalendar;
@@ -679,7 +680,8 @@
S_DECODETABLE[S_BASE64CHAR[i]] = (byte) i;
}
- private static int decode0(char[] ibuf, byte[] obuf, int wp) {
+ private static int decode0(char[] ibuf, byte[] obuf, int index) {
+ int wp = index;
int outlen = 3;
if (ibuf[3] == S_BASE64PAD)
outlen = 2;
@@ -703,7 +705,7 @@
obuf[wp] = (byte) (b2 << 6 & 0xc0 | b3 & 0x3f);
return 3;
default:
- throw new RuntimeException("internalError00");
+ throw new IllegalStateException("internalError00");
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
