Author: rfeng
Date: Mon Oct  2 16:25:18 2006
New Revision: 452260

URL: http://svn.apache.org/viewvc?view=rev&rev=452260
Log:
Fix checkstyle warnings

Modified:
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/builder/ConnectorImpl.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/DataBindingJavaInterfaceProcessor.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/DataBindingRegistryImpl.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/DataBindingWirePostProcessor.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/DataTypeLoader.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/DirectedGraph.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/Input2InputTransformer.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/MediatorImpl.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/Output2OutputTransformer.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/PipedTransformer.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/SimpleDataBinding.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/TransformationContextImpl.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/TransformerRegistryImpl.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/xml/DOMDataBinding.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/xml/DOMXMLStreamReader.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/xml/InputSource2Node.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/xml/InputSource2SAX.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/xml/InputStream2Node.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/xml/InputStream2SAX.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/xml/Node2Object.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/xml/Node2OutputStream.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/xml/Node2String.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/xml/Node2Writer.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/xml/Node2XMLStreamReader.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/xml/Reader2Node.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/xml/Reader2SAX.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/xml/SAX2DOM.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/xml/SAX2DOMPipe.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/xml/Source2ResultTransformer.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/xml/StAX2SAXAdapter.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/xml/StAXHelper.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/xml/StreamDataPipe.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/xml/String2SAX.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/xml/String2XMLStreamReader.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/xml/XMLStreamReader2Node.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/xml/XMLStreamReader2SAX.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/xml/XMLStreamReader2String.java
    
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/xml/XMLStringDataBinding.java
    
incubator/tuscany/java/sca/kernel/core/src/test/java/org/apache/tuscany/core/databinding/impl/DataBindingInterceptorTestCase.java
    
incubator/tuscany/java/sca/kernel/core/src/test/java/org/apache/tuscany/core/databinding/impl/DataBindingJavaInterfaceProcessorTestCase.java
    
incubator/tuscany/java/sca/kernel/core/src/test/java/org/apache/tuscany/core/databinding/impl/DataBindingLoaderTestCase.java
    
incubator/tuscany/java/sca/kernel/core/src/test/java/org/apache/tuscany/core/databinding/impl/DataBindingRegistryImplTestCase.java
    
incubator/tuscany/java/sca/kernel/core/src/test/java/org/apache/tuscany/core/databinding/impl/DataBindingTestCase.java
    
incubator/tuscany/java/sca/kernel/core/src/test/java/org/apache/tuscany/core/databinding/impl/DirectedGraphTestCase.java
    
incubator/tuscany/java/sca/kernel/core/src/test/java/org/apache/tuscany/core/databinding/impl/IDLTransformerTestCase.java
    
incubator/tuscany/java/sca/kernel/core/src/test/java/org/apache/tuscany/core/databinding/impl/MediatorImplTestCase.java
    
incubator/tuscany/java/sca/kernel/core/src/test/java/org/apache/tuscany/core/databinding/impl/TransformerRegistryImplTestCase.java
    
incubator/tuscany/java/sca/kernel/core/src/test/java/org/apache/tuscany/core/databinding/xml/DOM2StAXTestCase.java
    
incubator/tuscany/java/sca/kernel/core/src/test/java/org/apache/tuscany/core/databinding/xml/DataPipeTestCase.java
    
incubator/tuscany/java/sca/kernel/core/src/test/java/org/apache/tuscany/core/databinding/xml/Node2StringTestCase.java
    
incubator/tuscany/java/sca/kernel/core/src/test/java/org/apache/tuscany/core/databinding/xml/PushTransformationTestCase.java
    
incubator/tuscany/java/sca/kernel/core/src/test/java/org/apache/tuscany/core/databinding/xml/TraxTransformerTestCase.java

Modified: 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/builder/ConnectorImpl.java
URL: 
http://svn.apache.org/viewvc/incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/builder/ConnectorImpl.java?view=diff&rev=452260&r1=452259&r2=452260
==============================================================================
--- 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/builder/ConnectorImpl.java
 (original)
+++ 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/builder/ConnectorImpl.java
 Mon Oct  2 16:25:18 2006
@@ -289,7 +289,8 @@
                 throw e;
             }
             
-            Operation targetOp = (Operation) 
targetWire.getServiceContract().getCallbackOperations().get(operation.getName());
+            Operation targetOp =
+                
(Operation)targetWire.getServiceContract().getCallbackOperations().get(operation.getName());
             OutboundInvocationChain outboundChain = 
wireService.createOutboundChain(targetOp);
             targetWire.addSourceCallbackInvocationChain(source.getName(), 
targetOp, outboundChain);
             if (source instanceof Component) {

Modified: 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/DataBindingJavaInterfaceProcessor.java
URL: 
http://svn.apache.org/viewvc/incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/DataBindingJavaInterfaceProcessor.java?view=diff&rev=452260&r1=452259&r2=452260
==============================================================================
--- 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/DataBindingJavaInterfaceProcessor.java
 (original)
+++ 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/DataBindingJavaInterfaceProcessor.java
 Mon Oct  2 16:25:18 2006
@@ -46,11 +46,11 @@
 
     private static final String SIMPLE_JAVA_OBJECTS = "java.lang.Object";
 
-    private final static Class[] simpleTypes =
-            { Byte.class, Character.class, Short.class, Integer.class, 
Long.class, Float.class, Double.class,
-                    Date.class, Calendar.class, GregorianCalendar.class, 
Duration.class, XMLGregorianCalendar.class };
+    private static final Class[] SIMPLE_JAVA_TYPES =
+        {Byte.class, Character.class, Short.class, Integer.class, Long.class, 
Float.class, Double.class,
+         Date.class, Calendar.class, GregorianCalendar.class, Duration.class, 
XMLGregorianCalendar.class};
 
-    private final static Set<Class> simpleTypeSet = new 
HashSet<Class>(Arrays.asList(simpleTypes));
+    private static final Set<Class> SIMPLE_TYPE_SET = new 
HashSet<Class>(Arrays.asList(SIMPLE_JAVA_TYPES));
 
     public void visitInterface(Class<?> clazz, Class<?> callbackClass, 
JavaServiceContract contract)
         throws InvalidServiceContractException {
@@ -62,8 +62,9 @@
         }
     }
 
-
-    private void processInterface(Class<?> clazz, JavaServiceContract 
contract, Map<String, Operation<Type>> operations) {
+    private void processInterface(Class<?> clazz,
+                                  JavaServiceContract contract,
+                                  Map<String, Operation<Type>> operations) {
         DataType interfaceDataType = clazz.getAnnotation(DataType.class);
         if (interfaceDataType != null) {
             contract.setDataBinding(interfaceDataType.name());
@@ -99,14 +100,13 @@
         }
     }
 
-
     private void adjustSimpleType(org.apache.tuscany.spi.model.DataType<?> 
dataType, String dataBinding) {
         Type type = dataType.getPhysical();
         if (!(type instanceof Class)) {
             return;
         }
-        Class cls = (Class) dataType.getPhysical();
-        if (cls.isPrimitive() || simpleTypeSet.contains(cls)) {
+        Class cls = (Class)dataType.getPhysical();
+        if (cls.isPrimitive() || SIMPLE_TYPE_SET.contains(cls)) {
             dataType.setDataBinding(SIMPLE_JAVA_OBJECTS);
         } else if (cls == String.class && (dataBinding == null || 
!dataBinding.equals(String.class.getName()))) {
             // Identify the String as a simple type

Modified: 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/DataBindingRegistryImpl.java
URL: 
http://svn.apache.org/viewvc/incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/DataBindingRegistryImpl.java?view=diff&rev=452260&r1=452259&r2=452260
==============================================================================
--- 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/DataBindingRegistryImpl.java
 (original)
+++ 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/DataBindingRegistryImpl.java
 Mon Oct  2 16:25:18 2006
@@ -31,9 +31,6 @@
 public class DataBindingRegistryImpl implements DataBindingRegistry {
     private final Map<String, DataBinding> bindings = new HashMap<String, 
DataBinding>();
 
-    /**
-     * @see 
org.apache.tuscany.spi.databinding.DataBindingRegistry#getDataBinding(java.lang.String)
-     */
     public DataBinding getDataBinding(String id) {
         if (id == null) {
             return null;
@@ -41,16 +38,10 @@
         return bindings.get(id.toLowerCase());
     }
 
-    /**
-     * @see 
org.apache.tuscany.spi.databinding.DataBindingRegistry#register(org.apache.tuscany.spi.databinding.DataBinding)
-     */
     public void register(DataBinding dataBinding) {
         bindings.put(dataBinding.getName().toLowerCase(), dataBinding);
     }
 
-    /**
-     * @see 
org.apache.tuscany.spi.databinding.DataBindingRegistry#unregister(java.lang.String)
-     */
     public DataBinding unregister(String id) {
         if (id == null) {
             return null;
@@ -81,6 +72,7 @@
                 return dataType;
             }
         }
-        return null;    }
+        return null;
+    }
 
 }

Modified: 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/DataBindingWirePostProcessor.java
URL: 
http://svn.apache.org/viewvc/incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/DataBindingWirePostProcessor.java?view=diff&rev=452260&r1=452259&r2=452260
==============================================================================
--- 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/DataBindingWirePostProcessor.java
 (original)
+++ 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/DataBindingWirePostProcessor.java
 Mon Oct  2 16:25:18 2006
@@ -37,10 +37,9 @@
 import org.apache.tuscany.spi.wire.OutboundInvocationChain;
 import org.apache.tuscany.spi.wire.OutboundWire;
 
-
 /**
- * This processor is responsible to add an interceptor to invocation chain if 
the source and target operations have
- * different databinding requirements
+ * This processor is responsible to add an interceptor to invocation chain if
+ * the source and target operations have different databinding requirements
  */
 public class DataBindingWirePostProcessor extends WirePostProcessorExtension {
     private Mediator mediator;
@@ -51,10 +50,6 @@
         this.mediator = mediator;
     }
 
-    /**
-     * @see 
org.apache.tuscany.spi.builder.WirePostProcessor#process(org.apache.tuscany.spi.wire.OutboundWire,
-     *      org.apache.tuscany.spi.wire.InboundWire)
-     */
     public void process(OutboundWire source, InboundWire target) {
         Map<Operation<?>, OutboundInvocationChain> chains = 
source.getInvocationChains();
         for (Map.Entry<Operation<?>, OutboundInvocationChain> entry : 
chains.entrySet()) {
@@ -63,60 +58,63 @@
                 getTargetOperation(target.getInvocationChains().keySet(), 
sourceOperation.getName());
             String sourceDataBinding = getDataBinding(sourceOperation);
             String targetDataBinding = getDataBinding(targetOperation);
-            if (sourceDataBinding == null || targetDataBinding == null || 
!sourceDataBinding.equals(targetDataBinding)) {
-                // Add the interceptor to the source side because multiple 
references can be wired
+            if (sourceDataBinding == null || targetDataBinding == null
+                || !sourceDataBinding.equals(targetDataBinding)) {
+                // Add the interceptor to the source side because multiple
+                // references can be wired
                 // to the same service
                 DataBindingInteceptor interceptor =
-                        new DataBindingInteceptor(source, sourceOperation, 
target, targetOperation);
+                    new DataBindingInteceptor(source, sourceOperation, target, 
targetOperation);
                 interceptor.setMediator(mediator);
                 entry.getValue().addInterceptor(0, interceptor);
             }
         }
-        
+
         // Check if there's a callback
         Map callbackOperations = 
source.getServiceContract().getCallbackOperations();
         if (callbackOperations == null || callbackOperations.isEmpty()) {
             return;
         }
         Object targetAddress = source.getContainer().getName();
-        Map<Operation<?>, OutboundInvocationChain> callbackChains = 
target.getSourceCallbackInvocationChains(targetAddress);
+        Map<Operation<?>, OutboundInvocationChain> callbackChains =
+            target.getSourceCallbackInvocationChains(targetAddress);
         for (Map.Entry<Operation<?>, OutboundInvocationChain> entry : 
callbackChains.entrySet()) {
             Operation<?> sourceOperation = entry.getKey();
             Operation<?> targetOperation =
-                
getTargetOperation(source.getTargetCallbackInvocationChains().keySet(), 
sourceOperation.getName());
+                
getTargetOperation(source.getTargetCallbackInvocationChains().keySet(), 
sourceOperation
+                    .getName());
             String sourceDataBinding = getDataBinding(sourceOperation);
             String targetDataBinding = getDataBinding(targetOperation);
-            if (sourceDataBinding == null || targetDataBinding == null || 
!sourceDataBinding.equals(targetDataBinding)) {
-                // Add the interceptor to the source side because multiple 
references can be wired
+            if (sourceDataBinding == null || targetDataBinding == null
+                || !sourceDataBinding.equals(targetDataBinding)) {
+                // Add the interceptor to the source side because multiple
+                // references can be wired
                 // to the same service
                 DataBindingInteceptor interceptor =
-                        new DataBindingInteceptor(source, sourceOperation, 
target, targetOperation);
+                    new DataBindingInteceptor(source, sourceOperation, target, 
targetOperation);
                 interceptor.setMediator(mediator);
                 entry.getValue().addInterceptor(0, interceptor);
             }
-        }        
+        }
     }
 
-    /**
-     * @see 
org.apache.tuscany.spi.builder.WirePostProcessor#process(org.apache.tuscany.spi.wire.InboundWire,
-     *      org.apache.tuscany.spi.wire.OutboundWire)
-     */
     public void process(InboundWire source, OutboundWire target) {
         SCAObject container = source.getContainer();
         // Either Service or Reference
-        boolean isReference = (container instanceof Reference);
+        boolean isReference = container instanceof Reference;
 
         Map<Operation<?>, InboundInvocationChain> chains = 
source.getInvocationChains();
         for (Map.Entry<Operation<?>, InboundInvocationChain> entry : 
chains.entrySet()) {
             Operation<?> sourceOperation = entry.getKey();
             Operation<?> targetOperation =
-                    getTargetOperation(target.getInvocationChains().keySet(), 
sourceOperation.getName());
+                getTargetOperation(target.getInvocationChains().keySet(), 
sourceOperation.getName());
             String sourceDataBinding = getDataBinding(sourceOperation);
             String targetDataBinding = getDataBinding(targetOperation);
-            if (sourceDataBinding == null || targetDataBinding == null || 
!sourceDataBinding.equals(targetDataBinding)) {
+            if (sourceDataBinding == null || targetDataBinding == null
+                || !sourceDataBinding.equals(targetDataBinding)) {
                 // Add the interceptor to the source side
                 DataBindingInteceptor interceptor =
-                        new DataBindingInteceptor(source, sourceOperation, 
target, targetOperation);
+                    new DataBindingInteceptor(source, sourceOperation, target, 
targetOperation);
                 interceptor.setMediator(mediator);
                 if (isReference) {
                     // FIXME: We need a better way to position the interceptors

Modified: 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/DataTypeLoader.java
URL: 
http://svn.apache.org/viewvc/incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/DataTypeLoader.java?view=diff&rev=452260&r1=452259&r2=452260
==============================================================================
--- 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/DataTypeLoader.java
 (original)
+++ 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/DataTypeLoader.java
 Mon Oct  2 16:25:18 2006
@@ -36,9 +36,10 @@
  * The StAX loader for data type
  */
 public class DataTypeLoader extends LoaderExtension<DataType> {
-    public static final QName DATA_BINDING = new 
QName("http://tuscany.apache.org/xmlns/sca/databinding/1.0";, "databinding");
+    public static final QName DATA_BINDING =
+        new QName("http://tuscany.apache.org/xmlns/sca/databinding/1.0";, 
"databinding");
 
-    @Constructor( { "registry" })
+    @Constructor({"registry"})
     public DataTypeLoader(@Autowire LoaderRegistry registry) {
         super(registry);
     }
@@ -48,8 +49,9 @@
         return DATA_BINDING;
     }
 
-    public DataType load(CompositeComponent parent, XMLStreamReader reader, 
DeploymentContext deploymentContext)
-        throws XMLStreamException, LoaderException {
+    public DataType load(CompositeComponent parent,
+                         XMLStreamReader reader,
+                         DeploymentContext deploymentContext) throws 
XMLStreamException, LoaderException {
         assert DATA_BINDING.equals(reader.getName());
         String name = reader.getAttributeValue(null, "name");
         LoaderUtil.skipToEndElement(reader);

Modified: 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/DirectedGraph.java
URL: 
http://svn.apache.org/viewvc/incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/DirectedGraph.java?view=diff&rev=452260&r1=452259&r2=452260
==============================================================================
--- 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/DirectedGraph.java
 (original)
+++ 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/DirectedGraph.java
 Mon Oct  2 16:25:18 2006
@@ -29,10 +29,8 @@
 /**
  * Directed, weighted graph
  * 
- * @param <V>
- *            The type of vertex object
- * @param <E>
- *            The type of edge object
+ * @param <V> The type of vertex object
+ * @param <E> The type of edge object
  */
 public class DirectedGraph<V, E> {
     private final Map<V, Vertex> vertices = new HashMap<V, Vertex>();
@@ -40,18 +38,11 @@
     /**
      * Key for the shortest path cache
      */
-    private class VertexPair {
+    private final class VertexPair {
         private Vertex source;
 
         private Vertex target;
 
-        public boolean equals(Object object) {
-            if (!VertexPair.class.isInstance(object))
-                return false;
-            VertexPair pair = (VertexPair) object;
-            return source == pair.source && target == pair.target;
-        }
-
         /**
          * @param source
          * @param target
@@ -61,6 +52,21 @@
             this.source = source;
             this.target = target;
         }
+
+        public boolean equals(Object object) {
+            if (!VertexPair.class.isInstance(object)) {
+                return false;
+            }
+            VertexPair pair = (VertexPair)object;
+            return source == pair.source && target == pair.target;
+        }
+
+        public int hashCode() {
+            int x = source == null ? 0 : source.hashCode();
+            int y = target == null ? 0 : target.hashCode();
+            return x ^ y;
+        }
+
     }
 
     private final Map<VertexPair, Path> paths = new HashMap<VertexPair, 
Path>();
@@ -68,10 +74,11 @@
     /**
      * Vertex of a graph
      */
-    public class Vertex {
+    public final class Vertex {
         private V value;
 
-        // TODO: Do we want to support multiple edges for a vertex pair? If 
so, we should use a List instead of Map
+        // TODO: Do we want to support multiple edges for a vertex pair? If so,
+        // we should use a List instead of Map
         private Map<Vertex, Edge> outEdges = new HashMap<Vertex, Edge>();
 
         private Vertex(V value) {
@@ -95,7 +102,7 @@
     /**
      * An Edge connects two vertices in one direction
      */
-    public class Edge {
+    public final class Edge {
         private Vertex sourceVertex;
 
         private Vertex targetVertex;
@@ -148,11 +155,11 @@
         }
     }
 
-    private class Node implements Comparable<Node> {
+    private final class Node implements Comparable<Node> {
 
         private long distance = Integer.MAX_VALUE;
 
-        private Node previous = null; // NOPMD by rfeng on 9/26/06 9:17 PM
+        private Node previous; // NOPMD by rfeng on 9/26/06 9:17 PM
 
         private Vertex vertex; // NOPMD by rfeng on 9/26/06 9:17 PM
 
@@ -209,27 +216,30 @@
     }
 
     /**
-     * Get the shortes path from the source vertex to the target vertex using 
Dijkstra's algorithm. If there's no path, null will be returned. If the
-     * source is the same as the target, it returns a path with empty edges 
with weight 0.
+     * Get the shortes path from the source vertex to the target vertex using
+     * Dijkstra's algorithm. If there's no path, null will be returned. If the
+     * source is the same as the target, it returns a path with empty edges 
with
+     * weight 0.
      * 
-     * @param sourceValue
-     *            The value identifies the source
-     * @param targetValue
-     *            The value identifies the target
+     * @param sourceValue The value identifies the source
+     * @param targetValue The value identifies the target
      * @return The shortest path
      */
     public Path getShortestPath(V sourceValue, V targetValue) {
         Vertex source = getVertex(sourceValue);
-        if (source == null)
+        if (source == null) {
             return null;
+        }
         Vertex target = getVertex(targetValue);
-        if (target == null)
+        if (target == null) {
             return null;
+        }
 
         VertexPair pair = new VertexPair(source, target);
-        if (paths.containsKey(pair))
+        if (paths.containsKey(pair)) {
             return paths.get(pair);
-        
+        }
+
         // HACK: To support same vertex
         if (source == target) {
             Path path = new Path();
@@ -244,8 +254,9 @@
         Map<Vertex, Node> nodes = new HashMap<Vertex, Node>();
         for (Vertex v : vertices.values()) {
             Node node = new Node(v);
-            if (v == source)
+            if (v == source) {
                 node.distance = 0;
+            }
             nodes.put(v, node);
         }
 
@@ -272,7 +283,8 @@
     }
 
     /**
-     * Searches for the vertex u in the vertex set Q that has the least d[u] 
value. That vertex is removed from the set Q and returned to the user.
+     * Searches for the vertex u in the vertex set Q that has the least d[u]
+     * value. That vertex is removed from the set Q and returned to the user.
      * 
      * @param nodes
      * @return
@@ -286,10 +298,10 @@
     /**
      * The path between two vertices
      */
-    public class Path {
+    public final class Path {
         private List<Edge> edges = new LinkedList<Edge>();
 
-        private int weight = 0;
+        private int weight;
 
         public int getWeight() {
             return weight;
@@ -310,8 +322,9 @@
     }
 
     private Path getPath(Node t) {
-        if (t.distance == Integer.MAX_VALUE)
+        if (t.distance == Integer.MAX_VALUE) {
             return null;
+        }
         Path path = new Path();
         Node u = t;
         while (u.previous != null) {

Modified: 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/Input2InputTransformer.java
URL: 
http://svn.apache.org/viewvc/incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/Input2InputTransformer.java?view=diff&rev=452260&r1=452259&r2=452260
==============================================================================
--- 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/Input2InputTransformer.java
 (original)
+++ 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/Input2InputTransformer.java
 Mon Oct  2 16:25:18 2006
@@ -40,11 +40,12 @@
 import org.osoa.sca.annotations.Service;
 
 /**
- * This is a special transformer to transform the input from one IDL to the 
other one
+ * This is a special transformer to transform the input from one IDL to the
+ * other one
  */
 @Service(Transformer.class)
 public class Input2InputTransformer extends TransformerExtension<Object[], 
Object[]> implements
-        PullTransformer<Object[], Object[]> {
+    PullTransformer<Object[], Object[]> {
 
     private static final String IDL_INPUT = "idl:input";
 
@@ -102,14 +103,14 @@
      * @see org.apache.tuscany.spi.databinding.Transformer#getWeight()
      */
     public int getWeight() {
-        return 100;
+        return 10000;
     }
 
     @SuppressWarnings("unchecked")
     public Object[] transform(Object[] source, TransformationContext context) {
         DataType<List<DataType<?>>> sourceType = context.getSourceDataType();
-        Operation<?> sourceOp = (Operation<?>) 
sourceType.getMetadata(Operation.class.getName());
-        boolean sourceWrapped = (sourceOp != null && 
sourceOp.isWrapperStyle());
+        Operation<?> sourceOp = 
(Operation<?>)sourceType.getMetadata(Operation.class.getName());
+        boolean sourceWrapped = sourceOp != null && sourceOp.isWrapperStyle();
 
         WrapperHandler sourceWrapperHandler = null;
         if (sourceWrapped) {
@@ -117,8 +118,8 @@
         }
 
         DataType<List<DataType<QName>>> targetType = 
context.getTargetDataType();
-        Operation<?> targetOp = (Operation<?>) 
targetType.getMetadata(Operation.class.getName());
-        boolean targetWrapped = (targetOp != null && 
targetOp.isWrapperStyle());
+        Operation<?> targetOp = 
(Operation<?>)targetType.getMetadata(Operation.class.getName());
+        boolean targetWrapped = targetOp != null && targetOp.isWrapperStyle();
         WrapperHandler targetWrapperHandler = null;
         if (targetWrapped) {
             targetWrapperHandler = 
getWapperHandler(targetType.getLogical().get(0).getDataBinding(), true);
@@ -139,7 +140,7 @@
             }
             Object targetWrapper = targetWrapperHandler.create(wrapperElement, 
context);
             if (source == null) {
-                return new Object[] { targetWrapper };
+                return new Object[] {targetWrapper};
             }
             List<DataType<QName>> argTypes = 
wrapper.getUnwrappedInputType().getLogical();
 
@@ -147,10 +148,12 @@
                 ElementInfo argElement = 
wrapper.getInputChildElements().get(i);
                 DataType<QName> argType = argTypes.get(i);
                 Object child = source[i];
-                child = mediator.mediate(source[i], 
sourceType.getLogical().get(i), argType, context.getMetadata());
+                child =
+                    mediator.mediate(source[i], 
sourceType.getLogical().get(i), argType, context
+                        .getMetadata());
                 targetWrapperHandler.setChild(targetWrapper, i, argElement, 
child);
             }
-            return new Object[] { targetWrapper };
+            return new Object[] {targetWrapper};
         } else if (sourceWrapped && (!targetWrapped)) {
             // Wrapped to Unwrapped
             Object sourceWrapper = source[0];
@@ -160,13 +163,16 @@
             targetWrapperHandler = 
getWapperHandler(targetType.getLogical().get(0).getDataBinding(), false);
             if (targetWrapperHandler != null) {
                 ElementInfo wrapperElement = 
sourceOp.getWrapper().getInputWrapperElement();
-                // Object targetWrapper = 
targetWrapperHandler.create(wrapperElement, context);
+                // Object targetWrapper =
+                // targetWrapperHandler.create(wrapperElement, context);
                 DataType<QName> targetWrapperType =
-                        new 
DataType<QName>(targetType.getLogical().get(0).getDataBinding(), Object.class,
-                                wrapperElement.getQName());
+                    new 
DataType<QName>(targetType.getLogical().get(0).getDataBinding(), Object.class,
+                                        wrapperElement.getQName());
                 Object targetWrapper =
-                        mediator.mediate(sourceWrapper, 
sourceType.getLogical().get(0), targetWrapperType, context
-                                .getMetadata());
+                    mediator.mediate(sourceWrapper,
+                                     sourceType.getLogical().get(0),
+                                     targetWrapperType,
+                                     context.getMetadata());
                 for (int i = 0; i < childElements.size(); i++) {
                     ElementInfo childElement = childElements.get(i);
                     target[i] = targetWrapperHandler.getChild(targetWrapper, 
i, childElement);
@@ -175,19 +181,22 @@
                 for (int i = 0; i < childElements.size(); i++) {
                     ElementInfo childElement = childElements.get(i);
                     Object child = 
sourceWrapperHandler.getChild(sourceWrapper, i, childElement);
-                    DataType<QName> childType = 
sourceOp.getWrapper().getUnwrappedInputType().getLogical().get(i);
+                    DataType<QName> childType =
+                        
sourceOp.getWrapper().getUnwrappedInputType().getLogical().get(i);
                     target[i] =
-                            mediator.mediate(child, childType, 
targetType.getLogical().get(i), context.getMetadata());
+                        mediator.mediate(child, childType, 
targetType.getLogical().get(i), context
+                            .getMetadata());
                 }
             }
             return target;
         } else {
-            // Assuming wrapper to wrapper conversion can be handled here as 
well
+            // Assuming wrapper to wrapper conversion can be handled here as
+            // well
             Object[] newArgs = new Object[source.length];
             for (int i = 0; i < source.length; i++) {
                 Object child =
-                        mediator.mediate(source[i], 
sourceType.getLogical().get(i), targetType.getLogical().get(i),
-                                context.getMetadata());
+                    mediator.mediate(source[i], 
sourceType.getLogical().get(i), targetType.getLogical()
+                        .get(i), context.getMetadata());
                 newArgs[i] = child;
             }
             return newArgs;
@@ -198,7 +207,8 @@
         DataBinding dataBinding = 
dataBindingRegistry.getDataBinding(dataBindingId);
         WrapperHandler wrapperHandler = dataBinding == null ? null : 
dataBinding.getWrapperHandler();
         if (wrapperHandler == null && required) {
-            throw new TransformationException("No wrapper handler is provided 
for databinding: " + dataBindingId);
+            throw new TransformationException(
+                                              "No wrapper handler is provided 
for databinding: " + dataBindingId);
         }
         return wrapperHandler;
     }

Modified: 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/MediatorImpl.java
URL: 
http://svn.apache.org/viewvc/incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/MediatorImpl.java?view=diff&rev=452260&r1=452259&r2=452260
==============================================================================
--- 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/MediatorImpl.java
 (original)
+++ 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/MediatorImpl.java
 Mon Oct  2 16:25:18 2006
@@ -58,15 +58,15 @@
     }
 
     /**
-     * @see 
org.apache.tuscany.spi.databinding.Mediator#mediate(java.lang.Object, 
org.apache.tuscany.spi.model.DataType,
+     * @see 
org.apache.tuscany.spi.databinding.Mediator#mediate(java.lang.Object,
+     *      org.apache.tuscany.spi.model.DataType,
      *      org.apache.tuscany.spi.model.DataType, Map)
      */
     @SuppressWarnings("unchecked")
-    public Object mediate(
-            Object source,
-            DataType sourceDataType,
-            DataType targetDataType,
-            Map<Class<?>, Object> metadata) {
+    public Object mediate(Object source,
+                          DataType sourceDataType,
+                          DataType targetDataType,
+                          Map<Class<?>, Object> metadata) {
         if (source == null) {
             // Shortcut for null value
             return null;
@@ -84,49 +84,50 @@
 
         Object result = source;
         int size = path.size();
-        for (int i = 0; i < size; i++) {
+        int i = 0;
+        while (i < size) {
             Transformer transformer = path.get(i);
             TransformationContext context =
-                    createTransformationContext(sourceDataType, 
targetDataType, size, i, transformer, metadata);
+                createTransformationContext(sourceDataType, targetDataType, 
size, i, transformer, metadata);
             // the source and target type
             if (transformer instanceof PullTransformer) {
                 // For intermediate node, set data type to null
-                result = ((PullTransformer) transformer).transform(result, 
context);
+                result = ((PullTransformer)transformer).transform(result, 
context);
             } else if (transformer instanceof PushTransformer) {
-                DataPipe dataPipe = (i < size - 1) ? (DataPipe) path.get(++i) 
: null;
-                ((PushTransformer) transformer).transform(result, 
dataPipe.getSink(), context);
+                DataPipe dataPipe = (i < size - 1) ? (DataPipe)path.get(++i) : 
null;
+                ((PushTransformer)transformer).transform(result, 
dataPipe.getSink(), context);
                 result = dataPipe.getResult();
             }
+            i++;
         }
 
         return result;
     }
 
-    private TransformationContext createTransformationContext(
-            DataType sourceDataType,
-            DataType targetDataType,
-            int size,
-            int index,
-            Transformer transformer,
-            Map<Class<?>, Object> metadata) {
+    private TransformationContext createTransformationContext(DataType 
sourceDataType,
+                                                              DataType 
targetDataType,
+                                                              int size,
+                                                              int index,
+                                                              Transformer 
transformer,
+                                                              Map<Class<?>, 
Object> metadata) {
         DataType sourceType =
-                (index == 0) ? sourceDataType
-                        : new 
DataType<Object>(transformer.getSourceDataBinding(), Object.class, null);
+            (index == 0) ? sourceDataType : new 
DataType<Object>(transformer.getSourceDataBinding(),
+                                                                 Object.class, 
null);
         DataType targetType =
-                (index == size - 1) ? targetDataType : new 
DataType<Object>(transformer.getTargetDataBinding(),
-                        Object.class, null);
+            (index == size - 1) ? targetDataType : new 
DataType<Object>(transformer.getTargetDataBinding(),
+                                                                        
Object.class, null);
         ClassLoader classLoader = 
Thread.currentThread().getContextClassLoader();
-        TransformationContext context = new 
TransformationContextImpl(sourceType, targetType, classLoader, metadata);
+        TransformationContext context =
+            new TransformationContextImpl(sourceType, targetType, classLoader, 
metadata);
         return context;
     }
 
     @SuppressWarnings("unchecked")
-    public void mediate(
-            Object source,
-            Object target,
-            DataType sourceDataType,
-            DataType targetDataType,
-            Map<Class<?>, Object> metadata) {
+    public void mediate(Object source,
+                        Object target,
+                        DataType sourceDataType,
+                        DataType targetDataType,
+                        Map<Class<?>, Object> metadata) {
         if (source == null) {
             // Shortcut for null value
             return;
@@ -146,14 +147,14 @@
         for (int i = 0; i < size; i++) {
             Transformer transformer = path.get(i);
             TransformationContext context =
-                    createTransformationContext(sourceDataType, 
targetDataType, size, i, transformer, metadata);
+                createTransformationContext(sourceDataType, targetDataType, 
size, i, transformer, metadata);
 
             if (transformer instanceof PullTransformer) {
-                result = ((PullTransformer) transformer).transform(result, 
context);
+                result = ((PullTransformer)transformer).transform(result, 
context);
             } else if (transformer instanceof PushTransformer) {
-                DataPipe dataPipe = (i < size - 1) ? (DataPipe) path.get(++i) 
: null;
+                DataPipe dataPipe = (i < size - 1) ? (DataPipe)path.get(++i) : 
null;
                 Object sink = dataPipe != null ? dataPipe.getSink() : target;
-                ((PushTransformer) transformer).transform(result, sink, 
context);
+                ((PushTransformer)transformer).transform(result, sink, 
context);
                 result = (dataPipe != null) ? dataPipe.getResult() : null;
             }
         }

Modified: 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/Output2OutputTransformer.java
URL: 
http://svn.apache.org/viewvc/incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/Output2OutputTransformer.java?view=diff&rev=452260&r1=452259&r2=452260
==============================================================================
--- 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/Output2OutputTransformer.java
 (original)
+++ 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/Output2OutputTransformer.java
 Mon Oct  2 16:25:18 2006
@@ -40,11 +40,12 @@
 import org.osoa.sca.annotations.Service;
 
 /**
- * This is a special transformer to transform the output from one IDL to the 
other one
+ * This is a special transformer to transform the output from one IDL to the
+ * other one
  */
 @Service(Transformer.class)
 public class Output2OutputTransformer extends TransformerExtension<Object, 
Object> implements
-        PullTransformer<Object, Object> {
+    PullTransformer<Object, Object> {
     private static final String IDL_OUTPUT = "idl:output";
 
     protected DataBindingRegistry dataBindingRegistry;
@@ -113,7 +114,8 @@
         DataBinding dataBinding = 
dataBindingRegistry.getDataBinding(dataBindingId);
         WrapperHandler wrapperHandler = dataBinding == null ? null : 
dataBinding.getWrapperHandler();
         if (wrapperHandler == null) {
-            throw new TransformationException("No wrapper handler is provided 
for databinding: " + dataBindingId);
+            throw new TransformationException(
+                                              "No wrapper handler is provided 
for databinding: " + dataBindingId);
         }
         return wrapperHandler;
     }
@@ -127,16 +129,16 @@
     public Object transform(Object response, TransformationContext context) {
         try {
             DataType<DataType> sourceType = context.getSourceDataType();
-            Operation<?> sourceOp = (Operation<?>) 
sourceType.getMetadata(Operation.class.getName());
-            boolean sourceWrapped = (sourceOp != null && 
sourceOp.isWrapperStyle());
+            Operation<?> sourceOp = 
(Operation<?>)sourceType.getMetadata(Operation.class.getName());
+            boolean sourceWrapped = sourceOp != null && 
sourceOp.isWrapperStyle();
             WrapperHandler sourceWrapperHandler = null;
             if (sourceWrapped) {
                 sourceWrapperHandler = getWapperHandler(sourceOp);
             }
 
             DataType<DataType> targetType = context.getTargetDataType();
-            Operation<?> targetOp = (Operation<?>) 
targetType.getMetadata(Operation.class.getName());
-            boolean targetWrapped = (targetOp != null && 
targetOp.isWrapperStyle());
+            Operation<?> targetOp = 
(Operation<?>)targetType.getMetadata(Operation.class.getName());
+            boolean targetWrapped = targetOp != null && 
targetOp.isWrapperStyle();
             WrapperHandler targetWrapperHandler = null;
             if (targetWrapped) {
                 targetWrapperHandler = getWapperHandler(targetOp);
@@ -145,7 +147,8 @@
             if ((!sourceWrapped) && targetWrapped) {
                 // Unwrapped --> Wrapped
                 WrapperInfo wrapper = targetOp.getWrapper();
-                Object targetWrapper = 
targetWrapperHandler.create(wrapper.getOutputWrapperElement(), context);
+                Object targetWrapper =
+                    
targetWrapperHandler.create(wrapper.getOutputWrapperElement(), context);
                 if (response == null) {
                     return targetWrapper;
                 }
@@ -165,13 +168,14 @@
                 targetWrapperHandler = 
getWapperHandler(targetType.getLogical().getDataBinding());
                 if (targetWrapperHandler != null) {
                     ElementInfo wrapperElement = 
sourceOp.getWrapper().getInputWrapperElement();
-                    // Object targetWrapper = 
targetWrapperHandler.create(wrapperElement, context);
+                    // Object targetWrapper =
+                    // targetWrapperHandler.create(wrapperElement, context);
                     DataType<QName> targetWrapperType =
-                            new 
DataType<QName>(targetType.getLogical().getDataBinding(), Object.class, 
wrapperElement
-                                    .getQName());
+                        new 
DataType<QName>(targetType.getLogical().getDataBinding(), Object.class,
+                                            wrapperElement.getQName());
                     Object targetWrapper =
-                            mediator.mediate(sourceWrapper, 
sourceType.getLogical(), targetWrapperType, context
-                                    .getMetadata());
+                        mediator.mediate(sourceWrapper, 
sourceType.getLogical(), targetWrapperType, context
+                            .getMetadata());
                     return targetWrapperHandler.getChild(targetWrapper, 0, 
childElement);
                 } else {
                     Object child = 
sourceWrapperHandler.getChild(sourceWrapper, 0, childElement);
@@ -181,7 +185,7 @@
             } else {
                 // FIXME: Do we want to handle wrapped to wrapped?
                 return mediator.mediate(response, sourceType.getLogical(), 
targetType.getLogical(), context
-                        .getMetadata());
+                    .getMetadata());
             }
         } catch (Exception e) {
             throw new TransformationException(e);

Modified: 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/PipedTransformer.java
URL: 
http://svn.apache.org/viewvc/incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/PipedTransformer.java?view=diff&rev=452260&r1=452259&r2=452260
==============================================================================
--- 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/PipedTransformer.java
 (original)
+++ 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/PipedTransformer.java
 Mon Oct  2 16:25:18 2006
@@ -24,7 +24,9 @@
 import org.apache.tuscany.spi.databinding.TransformationContext;
 
 /**
- * A utility class to connect PushTransformer and DataPipe to create a 
PullTransformer
+ * A utility class to connect PushTransformer and DataPipe to create a
+ * PullTransformer
+ * 
  * @param <S> Source type
  * @param <I> Intermidate type
  * @param <R> Result type

Modified: 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/SimpleDataBinding.java
URL: 
http://svn.apache.org/viewvc/incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/SimpleDataBinding.java?view=diff&rev=452260&r1=452259&r2=452260
==============================================================================
--- 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/SimpleDataBinding.java
 (original)
+++ 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/SimpleDataBinding.java
 Mon Oct  2 16:25:18 2006
@@ -24,12 +24,15 @@
 import org.osoa.sca.annotations.Property;
 
 /**
- * Simple databinding represented by a base java type. A SCDL property 
className is used to customize
- * this component. 
+ * Simple databinding represented by a base java type. A SCDL property 
className
+ * is used to customize this component.
+ * <p>
+ * The following illustrates how a simple data binding can be registered as a
+ * SCA component.
  * <p>
- * The following illustrates how a simple data binding can be registered as a 
SCA component.<p>
  * &lt;component name="databinding.MyDataBinding"&gt;<br>
- * &nbsp;&nbsp;&lt;system:implementation.java 
class="org.apache.tuscany.databinding.impl.SimpleDataBinding"/&gt;<br>
+ * &nbsp;&nbsp;&lt;system:implementation.java
+ * class="org.apache.tuscany.databinding.impl.SimpleDataBinding"/&gt;<br>
  * &nbsp;&nbsp;&lt;property name="className"&gt;my.Type&lt;/property&gt;<br>
  * &lt/component&gt;
  */

Modified: 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/TransformationContextImpl.java
URL: 
http://svn.apache.org/viewvc/incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/TransformationContextImpl.java?view=diff&rev=452260&r1=452259&r2=452260
==============================================================================
--- 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/TransformationContextImpl.java
 (original)
+++ 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/TransformationContextImpl.java
 Mon Oct  2 16:25:18 2006
@@ -39,8 +39,10 @@
         setClassLoader(Thread.currentThread().getContextClassLoader());
     }
 
-    public TransformationContextImpl(DataType sourceDataType, DataType 
targetDataType, ClassLoader classLoader,
-            Map<Class<?>, Object> metadata) {
+    public TransformationContextImpl(DataType sourceDataType,
+                                     DataType targetDataType,
+                                     ClassLoader classLoader,
+                                     Map<Class<?>, Object> metadata) {
         super();
         this.sourceDataType = sourceDataType;
         this.targetDataType = targetDataType;
@@ -66,7 +68,7 @@
         this.targetDataType = targetDataType;
     }
 
-    final public void setClassLoader(ClassLoader classLoader) {
+    public final void setClassLoader(ClassLoader classLoader) {
         this.classLoaderRef = new WeakReference<ClassLoader>(classLoader);
     }
 

Modified: 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/TransformerRegistryImpl.java
URL: 
http://svn.apache.org/viewvc/incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/TransformerRegistryImpl.java?view=diff&rev=452260&r1=452259&r2=452260
==============================================================================
--- 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/TransformerRegistryImpl.java
 (original)
+++ 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/impl/TransformerRegistryImpl.java
 Mon Oct  2 16:25:18 2006
@@ -38,7 +38,10 @@
     }
 
     public void registerTransformer(Transformer transformer) {
-        graph.addEdge(transformer.getSourceDataBinding(), 
transformer.getTargetDataBinding(), transformer, transformer.getWeight());
+        graph.addEdge(transformer.getSourceDataBinding(),
+                      transformer.getTargetDataBinding(),
+                      transformer,
+                      transformer.getWeight());
     }
 
     public boolean unregisterTransformer(String sourceType, String resultType) 
{

Modified: 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/xml/DOMDataBinding.java
URL: 
http://svn.apache.org/viewvc/incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/xml/DOMDataBinding.java?view=diff&rev=452260&r1=452259&r2=452260
==============================================================================
--- 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/xml/DOMDataBinding.java
 (original)
+++ 
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/databinding/xml/DOMDataBinding.java
 Mon Oct  2 16:25:18 2006
@@ -28,7 +28,7 @@
  * DOM DataBinding
  */
 public class DOMDataBinding extends DataBindingExtension {
-    public final static String NAME = Node.class.getName();
+    public static final String NAME = Node.class.getName();
 
     public DOMDataBinding() {
         super(Node.class);



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to