Author: jboynes
Date: Fri Jan 5 07:34:44 2007
New Revision: 493050
URL: http://svn.apache.org/viewvc?view=rev&rev=493050
Log:
remove RuntimeInfo from ManagementService interface and initialize
JmxManagementService through its constructor
Modified:
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/services/management/jmx/JmxManagementService.java
incubator/tuscany/java/sca/kernel/spi/src/main/java/org/apache/tuscany/spi/services/management/ManagementService.java
incubator/tuscany/java/sca/runtime/standalone/jmx-host/src/main/java/org/apache/tuscany/runtime/standalone/jmx/JmxRuntimeImpl.java
Modified:
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/services/management/jmx/JmxManagementService.java
URL:
http://svn.apache.org/viewvc/incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/services/management/jmx/JmxManagementService.java?view=diff&rev=493050&r1=493049&r2=493050
==============================================================================
---
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/services/management/jmx/JmxManagementService.java
(original)
+++
incubator/tuscany/java/sca/kernel/core/src/main/java/org/apache/tuscany/core/services/management/jmx/JmxManagementService.java
Fri Jan 5 07:34:44 2007
@@ -33,17 +33,29 @@
*
* @version $Revision$ $Date$
*/
-public class JmxManagementService implements ManagementService<JmxRuntimeInfo>
{
+public class JmxManagementService implements ManagementService {
/**
* MBean server used by the JMX management service.
*/
- private MBeanServer mBeanServer;
+ private final MBeanServer mBeanServer;
/**
* Management domain used by the runtime.
*/
- private String managementDomain;
+ private final String managementDomain;
+
+
+ /**
+ * Constructor that initializes the MBeanServer and domain to use for
registering components.
+ *
+ * @param mBeanServer the MBeanServer components should be registered with
+ * @param managementDomain the JMX domain to use when generating
ObjectNames
+ */
+ public JmxManagementService(MBeanServer mBeanServer, String
managementDomain) {
+ this.mBeanServer = mBeanServer;
+ this.managementDomain = managementDomain;
+ }
/**
* @throws JmxException In case of an unexpected JMX exception.
@@ -61,15 +73,4 @@
}
}
-
- /**
- * Initializes the mbean server and management domain.
- *
- * @param runtimeInfo Runtime info for the management service.
- */
- public void setRuntimeIno(final JmxRuntimeInfo runtimeInfo) {
- this.mBeanServer = runtimeInfo.getMBeanServer();
- this.managementDomain = runtimeInfo.getManagementDomain();
- }
-
}
Modified:
incubator/tuscany/java/sca/kernel/spi/src/main/java/org/apache/tuscany/spi/services/management/ManagementService.java
URL:
http://svn.apache.org/viewvc/incubator/tuscany/java/sca/kernel/spi/src/main/java/org/apache/tuscany/spi/services/management/ManagementService.java?view=diff&rev=493050&r1=493049&r2=493050
==============================================================================
---
incubator/tuscany/java/sca/kernel/spi/src/main/java/org/apache/tuscany/spi/services/management/ManagementService.java
(original)
+++
incubator/tuscany/java/sca/kernel/spi/src/main/java/org/apache/tuscany/spi/services/management/ManagementService.java
Fri Jan 5 07:34:44 2007
@@ -18,31 +18,22 @@
*/
package org.apache.tuscany.spi.services.management;
-import org.apache.tuscany.host.RuntimeInfo;
import org.apache.tuscany.spi.component.Component;
/**
- * Interface for the management service abstraction. The implementaion
- * could be based on a variety of technologies including JMX, WSDM,
+ * Interface for the management service abstraction. The implementaion
+ * could be based on a variety of technologies including JMX, WSDM,
* SNMP etc.
- *
- * @version $Revision$ $Date$
*
+ * @version $Revision$ $Date$
*/
-public interface ManagementService<R extends RuntimeInfo> {
-
+public interface ManagementService {
+
/**
* Registers a component for management.
- *
- * @param name Name of the component.
+ *
+ * @param name Name of the component.
* @param component Component to be registered.
*/
void registerComponent(String name, Component component);
-
- /**
- * Sets the runtime info used by the management service.
- * @param runtimeInfo Runtime info for the management service.
- */
- void setRuntimeIno(R runtimeInfo);
-
}
Modified:
incubator/tuscany/java/sca/runtime/standalone/jmx-host/src/main/java/org/apache/tuscany/runtime/standalone/jmx/JmxRuntimeImpl.java
URL:
http://svn.apache.org/viewvc/incubator/tuscany/java/sca/runtime/standalone/jmx-host/src/main/java/org/apache/tuscany/runtime/standalone/jmx/JmxRuntimeImpl.java?view=diff&rev=493050&r1=493049&r2=493050
==============================================================================
---
incubator/tuscany/java/sca/runtime/standalone/jmx-host/src/main/java/org/apache/tuscany/runtime/standalone/jmx/JmxRuntimeImpl.java
(original)
+++
incubator/tuscany/java/sca/runtime/standalone/jmx-host/src/main/java/org/apache/tuscany/runtime/standalone/jmx/JmxRuntimeImpl.java
Fri Jan 5 07:34:44 2007
@@ -75,7 +75,8 @@
// register the runtime info provided by the host
JmxRuntimeInfo runtimeInfo = (JmxRuntimeInfo)getRuntimeInfo();
- ManagementService mgs = new JmxManagementService(runtimeInfo);
+ ManagementService mgs = new
JmxManagementService(runtimeInfo.getMBeanServer(),
+
runtimeInfo.getManagementDomain());
try {
systemComponent.registerJavaObject(RuntimeInfo.COMPONENT_NAME,
RuntimeInfo.class, runtimeInfo);
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
