Author: mcombellack
Date: Wed May 21 02:31:35 2008
New Revision: 658610
URL: http://svn.apache.org/viewvc?rev=658610&view=rev
Log:
Updated the code so that a shared instance of Random() is used to generate the
random numbers as this is more efficient and improves the quality of the random
numbers (FindBugs reported issue)
Modified:
incubator/tuscany/java/sca/modules/implementation-osgi/src/main/java/org/apache/tuscany/sca/implementation/osgi/invocation/OSGiInstanceWrapper.java
Modified:
incubator/tuscany/java/sca/modules/implementation-osgi/src/main/java/org/apache/tuscany/sca/implementation/osgi/invocation/OSGiInstanceWrapper.java
URL:
http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/implementation-osgi/src/main/java/org/apache/tuscany/sca/implementation/osgi/invocation/OSGiInstanceWrapper.java?rev=658610&r1=658609&r2=658610&view=diff
==============================================================================
---
incubator/tuscany/java/sca/modules/implementation-osgi/src/main/java/org/apache/tuscany/sca/implementation/osgi/invocation/OSGiInstanceWrapper.java
(original)
+++
incubator/tuscany/java/sca/modules/implementation-osgi/src/main/java/org/apache/tuscany/sca/implementation/osgi/invocation/OSGiInstanceWrapper.java
Wed May 21 02:31:35 2008
@@ -57,6 +57,7 @@
* @version $Rev$ $Date$
*/
public class OSGiInstanceWrapper<T> implements InstanceWrapper<T> {
+ private static final Random RANDOM_NUMBER_GENERATOR = new Random();
private OSGiAnnotations annotationProcessor;
private OSGiImplementationProvider provider;
@@ -223,7 +224,7 @@
ByteArrayOutputStream out = new ByteArrayOutputStream();
String EOL = System.getProperty("line.separator");
- String bundleName = "dummy.sca." + new Random().nextInt();
+ String bundleName = "dummy.sca." + RANDOM_NUMBER_GENERATOR.nextInt();
String manifestStr = "Manifest-Version: 1.0" + EOL +
