svn commit: r667210 - /incubator/tuscany/java/sca/modules/implementation-java-runtime/src/main/java/org/apache/tuscany/sca/implementation/java/invocation/JavaComponentContextProvider.java

[rfeng]

Author: rfeng
Date: Thu Jun 12 12:35:13 2008
New Revision: 667210

URL: http://svn.apache.org/viewvc?rev=667210&view=rev
Log:
Fix for TUSCANY-2383. We were checking if the field is public upon the 
injection of a property value. It was an interpretion of the Java A&A:

1349 Properties may also be injected via public setter methods even when the 
@Property annotation is not
1350 present. However, the @Property annotation must be used in order to inject 
a property onto a non-public
1351 field. In the case where there is no @Property annotation, the name of the 
property is the same as the
1352 name of the field or setter.

See TUSCANY-2289 too.

Modified:
    
incubator/tuscany/java/sca/modules/implementation-java-runtime/src/main/java/org/apache/tuscany/sca/implementation/java/invocation/JavaComponentContextProvider.java

Modified: 
incubator/tuscany/java/sca/modules/implementation-java-runtime/src/main/java/org/apache/tuscany/sca/implementation/java/invocation/JavaComponentContextProvider.java
URL: 
http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/implementation-java-runtime/src/main/java/org/apache/tuscany/sca/implementation/java/invocation/JavaComponentContextProvider.java?rev=667210&r1=667209&r2=667210&view=diff
==============================================================================
--- 
incubator/tuscany/java/sca/modules/implementation-java-runtime/src/main/java/org/apache/tuscany/sca/implementation/java/invocation/JavaComponentContextProvider.java
 (original)
+++ 
incubator/tuscany/java/sca/modules/implementation-java-runtime/src/main/java/org/apache/tuscany/sca/implementation/java/invocation/JavaComponentContextProvider.java
 Thu Jun 12 12:35:13 2008
@@ -114,12 +114,15 @@
         if (element != null && configuredProperty.getValue() != null) {
             if (!(element.getAnchor() instanceof Constructor)) {
                 if(element.getElementType() == ElementType.FIELD) {
-                    Field field = (Field)element.getAnchor();
+                    // Field field = (Field)element.getAnchor();
+                    instanceFactoryProvider.getInjectionSites().add(element);
+                    /*
                     if(Modifier.isPublic(field.getModifiers())) {
                         
instanceFactoryProvider.getInjectionSites().add(element);
                     } else 
if(field.getAnnotation(org.osoa.sca.annotations.Property.class) != null) {
                         
instanceFactoryProvider.getInjectionSites().add(element);
                     }
+                    */
                 } else {
                     instanceFactoryProvider.getInjectionSites().add(element);
                 }