Hi Jeremy, I have attached a patch to the Jira. The URL is:
http://issues.apache.org/jira/secure/ManageAttachments.jspa?id=12350253 Please take a look and let me know what you think. I have kept the changes minimal. On 10/19/06, Jeremy Boynes <[EMAIL PROTECTED]> wrote:
On Oct 18, 2006, at 11:26 PM, Jojo wrote: > Hi Jeremy, > > Thanks for the reply. See my comments in-line. > > On 10/18/06, Jeremy Boynes <[EMAIL PROTECTED]> wrote: >> >> I think getting the two versions is a pom problem, possibly related >> to the issue with the plugin. > > > You are right, the pom.xml file under sca-java-M2\samples defines the > versions as : > > <properties> > <scaVersion>1.0-incubator-M2-SNAPSHOT</scaVersion> > <sdoVersion>1.0-incubator-M2</sdoVersion> > <dasVersion>1.0-incubator-M2-SNAPSHOT</dasVersion> > <specVersion>0.95</specVersion> > </properties> > > I guess for the branch, we might need to change the SNAPSHOT > versions to M2 > versions. Is there a plan for this ? We would do this when we tag the branch - we don't want different versions of non-SNAPSHOT artifacts floating around. > > For the plugin having a hard coded version, it isn't the best way to >> do it and there's a JIRA open[1] to fix this. If you could help with >> the JIRA that would be appreciated. > > > > I took a look at the JIRA. It is already assigned to Meeraj, Should > I go > ahead and fix it ? Also I would like to know if we are targetting > this for > M2. Patches are always welcome so if you have a chance to fix is please do. The main (non-sample) code in M2 is basically frozen bar essential fixes which come in before we create the final tag (which is primarily waiting for Axis2 1.1 to release). I would suggest creating the patch for trunk and then we'd see how big/risky it was and make a decision on applying it to M2 as well. -- Jeremy --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
-- Warm regards, jojo.
