ant elder wrote:
Please review and vote on the 0.90 release artifacts of Tuscany SCA for
Java.
The artifacts are available for review at:
http://people.apache.org/~antelder/tuscany/0.90-rc1/
This includes the binary and source distributions, the RAT reports,
and the
Maven staging repository.
The SVN tag for the release is:
https://svn.apache.org/repos/asf/incubator/tuscany/tags/java/sca/0.90-incubating/
Looks ok to me so here's my +1.
Thanks in advance,
...ant
I've reviewed the binary release on Linux. It looks pretty good to me
but I have a few comments, some minor, some more important:
1) CHANGES file, I'd suggest to move the API / user items to the top and
move the SPI related section to the bottom, and change Host extensions
to Host integrations or Host environments.
2) RELEASE_NOTES, I'd suggest to change "The Tuscany all and manifest
jars..." to "The tuscany-sca-all and tuscany-sca-manifest jars..."
3) In docs/, wer'e missing Javadoc for a number of SPI packages listed
in CHANGES, and more importantly, Javadoc for the SCA Java APIs .
4) I couldn't find text explaining that tuscany-sca-all contains all the
other Tuscany JARs and that you don't need them as well if you're using it.
5) The RMI READMEs seem out of sync. Also I found having the
build_client and build_server in both the rmi-reference and rmi-service
samples confusing, how about just having a single build.xml like the
other samples do (e.g. helloworld-ws-reference and
helloworld-ws-service). Build.xml would start the server in rmi-service
and the client in rmi-reference.
6) The implementation-crud-client does not work (I'm probably
responsible for breaking this one...)
7) Like Ant said in another email, it would be good to rename
calculator-web to calculator-webapp
8) I'd suggest to rename the binding-echo-appl and
implementation-crud-client to something else, as most of these samples
are appls as well, and implementation-crud is not a client, but I don't
have a good name proposal. I had proposed to rename echo-binding to
echo-binding-extension but it doesn't fit either as none of our other
extension modules are named *-extension. These two samples look too
complicated to me now, but I'm not sure if we can do anything about it
for this release.
8) In the helloworld-jsonrpc sample, clicking the
services/HelloWorldService link at the top of the page shows an
exception, this probably normal as the server expects a JSON request,
but confusing. I'd suggest to remove that link.
9) I could not find text in a README describing how I would use the
binary distro, load one of the samples in Eclipse or IDEA and run it
from there. As a developer that's one of the things I'd like to do first
to browse the sample code and experiment with it. The steps described in
the samples README only apply to the source distro and require Maven
expertise, we should document simpler steps for somebody using the
binary distro without Maven.
10) The samples/README says that you can build with mvn from both the
source and binary distros, but the steps seem to apply to only the
source distro.
11) None of the samples shows the use of META-INF/sca-deployables. I'd
suggest to have one of the Webapp samples use that instead of
sca-contribution.xml.
I think it would be good to respin another release candidate with fixes
for (1), (3), (4), (5), (6), (9) and (11) at least...
Thanks.
--
Jean-Sebastien
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
