The targetNameSpace were only added on the Calculator and Chat samples, as suggested on the JIRA 1330. The other changes were merely cosmetic (such as alignments) or adding missing headers on some composite files.
What's the suggestion here ? To remove the targetNamespace from the Calculator samples ? On 7/19/07, Mike Edwards <[EMAIL PROTECTED]> wrote:
Folks, I tend to agree with Ant. The namespace gets necessary once we get into inter-contribution sharing of artifacts and then the namespace is essential, but I dont think it is necessary or useful in the simpler examples. I DO think we need to add the XSD location for the SCA namespace, however - this is useful for tooling using the composite files, for example. This is covered by JIRA 1443. Yours, Mike. ant elder wrote: > Do we really need these, line 1033 of the assembly spec says the > targetNamespace is optional, and the samples don't use the sample > namespace? As they're samples isn't it good to keep the XML as bare and > simple as possible? > > ...ant > > On 7/19/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: >> >> Author: lresende >> Date: Wed Jul 18 22:33:05 2007 >> New Revision: 557494 >> >> URL: http://svn.apache.org/viewvc?view=rev&rev=557494 >> Log: >> TUSCANY-1330 - Adding targetNameSpace to sample composites >> >> Modified: >> >> >> incubator/tuscany/java/sca/samples/calculator-rmi-reference/src/main/resources/CalculatorRMIReference.composite >> >> >> >> incubator/tuscany/java/sca/samples/calculator-rmi-service/src/main/resources/CalculatorRMIServer.composite >> >> >> >> incubator/tuscany/java/sca/samples/calculator-script/src/main/resources/Calculator.composite >> >> >> >> incubator/tuscany/java/sca/samples/calculator-webapp/src/main/resources/Calculator.composite >> >> >> >> incubator/tuscany/java/sca/samples/calculator/src/main/resources/Calculator.composite >> >> >> >> incubator/tuscany/java/sca/samples/chat-webapp/src/main/resources/chat.composite >> >> >> >> incubator/tuscany/java/sca/samples/das-service-web/src/main/resources/dasservice.composite >> >> >> >> incubator/tuscany/java/sca/samples/das-service/src/main/resources/dasservice.composite >> >> >> >> incubator/tuscany/java/sca/samples/helloworld-dojo/src/main/resources/jsonrpc.composite >> >> >> >> incubator/tuscany/java/sca/samples/helloworld-jsonrpc/src/main/resources/jsonrpc.composite >> >> >> >> incubator/tuscany/java/sca/samples/implementation-notification/src/test/resources/TrafficAdvisoryNotification.composite >> >> >> >> incubator/tuscany/java/sca/samples/simple-bigbank-spring/src/main/resources/StockQuote.composite >> >> >> >> incubator/tuscany/java/sca/samples/simple-bigbank/src/main/resources/StockQuote.composite >> >> >> >> incubator/tuscany/java/sca/samples/web-resource/src/main/resources/WebResource.composite >> >> >> Modified: >> incubator/tuscany/java/sca/samples/calculator-rmi-reference/src/main/resources/CalculatorRMIReference.composite >> >> URL: >> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/samples/calculator-rmi-reference/src/main/resources/CalculatorRMIReference.composite?view=diff&rev=557494&r1=557493&r2=557494 >> >> >> ============================================================================== >> >> --- >> incubator/tuscany/java/sca/samples/calculator-rmi-reference/src/main/resources/CalculatorRMIReference.composite >> >> (original) >> +++ >> incubator/tuscany/java/sca/samples/calculator-rmi-reference/src/main/resources/CalculatorRMIReference.composite >> >> Wed Jul 18 22:33:05 2007 >> @@ -18,6 +18,8 @@ >> * under the License. >> --> >> <composite xmlns="http://www.osoa.org/xmlns/sca/1.0"; >> + targetNamespace="http://sample"; >> + xmlns:sample="http://sample"; >> name="Calculator"> >> >> <component name="CalculatorServiceComponent"> >> >> Modified: >> incubator/tuscany/java/sca/samples/calculator-rmi-service/src/main/resources/CalculatorRMIServer.composite >> >> URL: >> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/samples/calculator-rmi-service/src/main/resources/CalculatorRMIServer.composite?view=diff&rev=557494&r1=557493&r2=557494 >> >> >> ============================================================================== >> >> --- >> incubator/tuscany/java/sca/samples/calculator-rmi-service/src/main/resources/CalculatorRMIServer.composite >> >> (original) >> +++ >> incubator/tuscany/java/sca/samples/calculator-rmi-service/src/main/resources/CalculatorRMIServer.composite >> >> Wed Jul 18 22:33:05 2007 >> @@ -18,6 +18,8 @@ >> * under the License. >> --> >> <composite xmlns="http://www.osoa.org/xmlns/sca/1.0"; >> + targetNamespace="http://sample"; >> + xmlns:sample="http://sample"; >> name="Calculator"> >> >> <component name="CalculatorServiceComponent"> >> >> Modified: >> incubator/tuscany/java/sca/samples/calculator-script/src/main/resources/Calculator.composite >> >> URL: >> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/samples/calculator-script/src/main/resources/Calculator.composite?view=diff&rev=557494&r1=557493&r2=557494 >> >> >> ============================================================================== >> >> --- >> incubator/tuscany/java/sca/samples/calculator-script/src/main/resources/Calculator.composite >> >> (original) >> +++ >> incubator/tuscany/java/sca/samples/calculator-script/src/main/resources/Calculator.composite >> >> Wed Jul 18 22:33:05 2007 >> @@ -18,6 +18,8 @@ >> * under the License. >> --> >> <composite xmlns="http://www.osoa.org/xmlns/sca/1.0"; >> + targetNamespace="http://sample"; >> + xmlns:sample="http://sample"; >> name="Calculator"> >> >> <component name="CalculatorServiceComponent"> >> >> Modified: >> incubator/tuscany/java/sca/samples/calculator-webapp/src/main/resources/Calculator.composite >> >> URL: >> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/samples/calculator-webapp/src/main/resources/Calculator.composite?view=diff&rev=557494&r1=557493&r2=557494 >> >> >> ============================================================================== >> >> --- >> incubator/tuscany/java/sca/samples/calculator-webapp/src/main/resources/Calculator.composite >> >> (original) >> +++ >> incubator/tuscany/java/sca/samples/calculator-webapp/src/main/resources/Calculator.composite >> >> Wed Jul 18 22:33:05 2007 >> @@ -18,6 +18,8 @@ >> * under the License. >> --> >> <composite xmlns="http://www.osoa.org/xmlns/sca/1.0"; >> + targetNamespace="http://sample"; >> + xmlns:sample="http://sample"; >> name="Calculator"> >> >> <component name="CalculatorServiceComponent"> >> >> Modified: >> incubator/tuscany/java/sca/samples/calculator/src/main/resources/Calculator.composite >> >> URL: >> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/samples/calculator/src/main/resources/Calculator.composite?view=diff&rev=557494&r1=557493&r2=557494 >> >> >> ============================================================================== >> >> --- >> incubator/tuscany/java/sca/samples/calculator/src/main/resources/Calculator.composite >> >> (original) >> +++ >> incubator/tuscany/java/sca/samples/calculator/src/main/resources/Calculator.composite >> >> Wed Jul 18 22:33:05 2007 >> @@ -18,6 +18,8 @@ >> * under the License. >> --> >> <composite xmlns="http://www.osoa.org/xmlns/sca/1.0"; >> + targetNamespace="http://sample"; >> + xmlns:sample="http://sample"; >> name="Calculator"> >> >> <component name="CalculatorServiceComponent"> >> >> Modified: >> incubator/tuscany/java/sca/samples/chat-webapp/src/main/resources/chat.composite >> >> URL: >> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/samples/chat-webapp/src/main/resources/chat.composite?view=diff&rev=557494&r1=557493&r2=557494 >> >> >> ============================================================================== >> >> --- >> incubator/tuscany/java/sca/samples/chat-webapp/src/main/resources/chat.composite >> >> (original) >> +++ >> incubator/tuscany/java/sca/samples/chat-webapp/src/main/resources/chat.composite >> >> Wed Jul 18 22:33:05 2007 >> @@ -18,6 +18,8 @@ >> * under the License. >> --> >> <composite xmlns="http://www.osoa.org/xmlns/sca/1.0"; >> + targetNamespace="http://sample"; >> + xmlns:sample="http://sample"; >> name="Chat"> >> >> <service name="ChatService" promote="ChatComponent"> >> >> Modified: >> incubator/tuscany/java/sca/samples/das-service-web/src/main/resources/dasservice.composite >> >> URL: >> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/samples/das-service-web/src/main/resources/dasservice.composite?view=diff&rev=557494&r1=557493&r2=557494 >> >> >> ============================================================================== >> >> --- >> incubator/tuscany/java/sca/samples/das-service-web/src/main/resources/dasservice.composite >> >> (original) >> +++ >> incubator/tuscany/java/sca/samples/das-service-web/src/main/resources/dasservice.composite >> >> Wed Jul 18 22:33:05 2007 >> @@ -18,9 +18,9 @@ >> * under the License. >> --> >> <composite xmlns="http://www.osoa.org/xmlns/sca/1.0"; >> - targetNamespace="http://sample"; >> - xmlns:sample="http://sample"; >> - name="DASService"> >> + targetNamespace="http://das-service"; >> + xmlns:das-service="http://das-service"; >> + name="DASService"> >> >> <service name="DASService" promote="DASServiceComponent"> >> <interface.java interface="das.DASService"/> >> >> Modified: >> incubator/tuscany/java/sca/samples/das-service/src/main/resources/dasservice.composite >> >> URL: >> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/samples/das-service/src/main/resources/dasservice.composite?view=diff&rev=557494&r1=557493&r2=557494 >> >> >> ============================================================================== >> >> --- >> incubator/tuscany/java/sca/samples/das-service/src/main/resources/dasservice.composite >> >> (original) >> +++ >> incubator/tuscany/java/sca/samples/das-service/src/main/resources/dasservice.composite >> >> Wed Jul 18 22:33:05 2007 >> @@ -18,8 +18,9 @@ >> * under the License. >> --> >> <composite xmlns="http://www.osoa.org/xmlns/sca/1.0"; >> - targetNamespace="http://DASService"; >> - name="DASService"> >> + targetNamespace="http://das-service"; >> + xmlns:das-service="http://das-service"; >> + name="DASService"> >> >> <service name="DASService" promote="DASServiceComponent"> >> <interface.java interface="das.DASService"/> >> >> Modified: >> incubator/tuscany/java/sca/samples/helloworld-dojo/src/main/resources/jsonrpc.composite >> >> URL: >> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/samples/helloworld-dojo/src/main/resources/jsonrpc.composite?view=diff&rev=557494&r1=557493&r2=557494 >> >> >> ============================================================================== >> >> --- >> incubator/tuscany/java/sca/samples/helloworld-dojo/src/main/resources/jsonrpc.composite >> >> (original) >> +++ >> incubator/tuscany/java/sca/samples/helloworld-dojo/src/main/resources/jsonrpc.composite >> >> Wed Jul 18 22:33:05 2007 >> @@ -19,8 +19,8 @@ >> --> >> >> <composite xmlns="http://www.osoa.org/xmlns/sca/1.0"; >> - targetNamespace="http://sample"; >> - xmlns:sample="http://sample"; >> + targetNamespace="http://sample"; >> + xmlns:sample="http://sample"; >> name="helloworldjsonrpc"> >> >> <service name="HelloWorldService" >> promote="HelloWorldJSONServiceComponent/HelloWorldService"> >> >> Modified: >> incubator/tuscany/java/sca/samples/helloworld-jsonrpc/src/main/resources/jsonrpc.composite >> >> URL: >> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/samples/helloworld-jsonrpc/src/main/resources/jsonrpc.composite?view=diff&rev=557494&r1=557493&r2=557494 >> >> >> ============================================================================== >> >> --- >> incubator/tuscany/java/sca/samples/helloworld-jsonrpc/src/main/resources/jsonrpc.composite >> >> (original) >> +++ >> incubator/tuscany/java/sca/samples/helloworld-jsonrpc/src/main/resources/jsonrpc.composite >> >> Wed Jul 18 22:33:05 2007 >> @@ -19,8 +19,8 @@ >> --> >> >> <composite xmlns="http://www.osoa.org/xmlns/sca/1.0"; >> - targetNamespace="http://sample"; >> - xmlns:sample="http://sample"; >> + targetNamespace="http://sample"; >> + xmlns:sample="http://sample"; >> name="helloworldjsonrpc"> >> >> <service name="HelloWorldService" >> promote="HelloWorldJSONServiceComponent/HelloWorldService"> >> >> Modified: >> incubator/tuscany/java/sca/samples/implementation-notification/src/test/resources/TrafficAdvisoryNotification.composite >> >> URL: >> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/samples/implementation-notification/src/test/resources/TrafficAdvisoryNotification.composite?view=diff&rev=557494&r1=557493&r2=557494 >> >> >> ============================================================================== >> >> --- >> incubator/tuscany/java/sca/samples/implementation-notification/src/test/resources/TrafficAdvisoryNotification.composite >> >> (original) >> +++ >> incubator/tuscany/java/sca/samples/implementation-notification/src/test/resources/TrafficAdvisoryNotification.composite >> >> Wed Jul 18 22:33:05 2007 >> @@ -19,6 +19,8 @@ >> --> >> >> <composite xmlns="http://www.osoa.org/xmlns/sca/1.0"; >> + targetNamespace="http://sample"; >> + xmlns:sample="http://sample"; >> name="TrafficAdvisoryNotificationLocalComposite"> >> >> <component name="TrafficAdvisoryProducer"> >> >> Modified: >> incubator/tuscany/java/sca/samples/simple-bigbank-spring/src/main/resources/StockQuote.composite >> >> URL: >> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/samples/simple-bigbank-spring/src/main/resources/StockQuote.composite?view=diff&rev=557494&r1=557493&r2=557494 >> >> >> ============================================================================== >> >> --- >> incubator/tuscany/java/sca/samples/simple-bigbank-spring/src/main/resources/StockQuote.composite >> >> (original) >> +++ >> incubator/tuscany/java/sca/samples/simple-bigbank-spring/src/main/resources/StockQuote.composite >> >> Wed Jul 18 22:33:05 2007 >> @@ -1,7 +1,25 @@ >> <?xml version="1.0" encoding="UTF-8"?> >> +<!-- >> + * Licensed to the Apache Software Foundation (ASF) under one >> + * or more contributor license agreements. See the NOTICE file >> + * distributed with this work for additional information >> + * regarding copyright ownership. The ASF licenses this file >> + * to you under the Apache License, Version 2.0 (the >> + * "License"); you may not use this file except in compliance >> + * with the License. You may obtain a copy of the License at >> + * >> + * http://www.apache.org/licenses/LICENSE-2.0 >> + * >> + * Unless required by applicable law or agreed to in writing, >> + * software distributed under the License is distributed on an >> + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY >> + * KIND, either express or implied. See the License for the >> + * specific language governing permissions and limitations >> + * under the License. >> +--> >> <composite xmlns="http://www.osoa.org/xmlns/sca/1.0"; >> - targetNamespace="http://stockquote"; >> - name="StockQuote"> >> + targetNamespace="http://stockquote"; >> + name="StockQuote"> >> >> <service name="StockQuoteService" >> promote="StockQuoteServiceComponent"/> >> >> >> Modified: >> incubator/tuscany/java/sca/samples/simple-bigbank/src/main/resources/StockQuote.composite >> >> URL: >> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/samples/simple-bigbank/src/main/resources/StockQuote.composite?view=diff&rev=557494&r1=557493&r2=557494 >> >> >> ============================================================================== >> >> --- >> incubator/tuscany/java/sca/samples/simple-bigbank/src/main/resources/StockQuote.composite >> >> (original) >> +++ >> incubator/tuscany/java/sca/samples/simple-bigbank/src/main/resources/StockQuote.composite >> >> Wed Jul 18 22:33:05 2007 >> @@ -1,7 +1,26 @@ >> <?xml version="1.0" encoding="UTF-8"?> >> +<!-- >> + * Licensed to the Apache Software Foundation (ASF) under one >> + * or more contributor license agreements. See the NOTICE file >> + * distributed with this work for additional information >> + * regarding copyright ownership. The ASF licenses this file >> + * to you under the Apache License, Version 2.0 (the >> + * "License"); you may not use this file except in compliance >> + * with the License. You may obtain a copy of the License at >> + * >> + * http://www.apache.org/licenses/LICENSE-2.0 >> + * >> + * Unless required by applicable law or agreed to in writing, >> + * software distributed under the License is distributed on an >> + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY >> + * KIND, either express or implied. See the License for the >> + * specific language governing permissions and limitations >> + * under the License. >> +--> >> + >> <composite xmlns="http://www.osoa.org/xmlns/sca/1.0"; >> - targetNamespace="http://stockquote"; >> - name="StockQuote"> >> + targetNamespace="http://stockquote"; >> + name="StockQuote"> >> >> <service name="StockQuoteService" >> promote="StockQuoteServiceComponent"/> >> >> >> Modified: >> incubator/tuscany/java/sca/samples/web-resource/src/main/resources/WebResource.composite >> >> URL: >> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/samples/web-resource/src/main/resources/WebResource.composite?view=diff&rev=557494&r1=557493&r2=557494 >> >> >> ============================================================================== >> >> --- >> incubator/tuscany/java/sca/samples/web-resource/src/main/resources/WebResource.composite >> >> (original) >> +++ >> incubator/tuscany/java/sca/samples/web-resource/src/main/resources/WebResource.composite >> >> Wed Jul 18 22:33:05 2007 >> @@ -18,8 +18,8 @@ >> * under the License. >> --> >> <composite xmlns="http://www.osoa.org/xmlns/sca/1.0"; >> - targetNamespace="http://web"; >> - name="WebResource"> >> + targetNamespace="http://web"; >> + name="WebResource"> >> >> <service name="WebResource" promote="WebResourceComponent"> >> <binding.resource uri="http://localhost:8083/myWeb"/> >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [EMAIL PROTECTED] >> For additional commands, e-mail: [EMAIL PROTECTED] >> >> > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
-- Luciano Resende Apache Tuscany Committer http://people.apache.org/~lresende http://lresende.blogspot.com/ --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
