Comments in line, but to summarize I think the answer to the three licensing questions is that its ok.
...ant On 8/25/07, Simon Laws <[EMAIL PROTECTED]> wrote: > > On 8/25/07, ant elder <[EMAIL PROTECTED]> wrote: > > > > Please review and vote on the 0.99 release artifacts of Tuscany SCA for > > Java. > > > > The artifacts are available for review at: > > http://people.apache.org/~antelder/tuscany/0.99-RC2/ > > > > This includes the signed binary and source distributions, the RAT > reports, > > and > > the Maven staging repository. > > > > The SVN tag for the release is: > > > > > https://svn.apache.org/repos/asf/incubator/tuscany/tags/java/sca/0.99-incubating/ > > > > Many thanks, > > > > ...ant > > > > (note, the artifacts are still uploading so if it looks like something's > > missing please just wait a bit) > > > > The summary for me is that I have licensing questions that affect my vote. > > 1/ !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating > > /samples/calculator-webapp-ws/src/test/java/calculator/CalculatorTestCaseOFF.java > Is an empty file. Can we just remove this without a restarting the > vote? Can't remove it without a respin. It doesn't cause any licensing issues that its there. 2/ LICENSE > Is it ok that the the tuscany sca modules are not listed against the > Apache2 license? Yes its ok. The artifacts under the Apache license that are mentioned in the LICENSE file is just to make it clear, i think its pretty clear the the Apache Tuscany modules are covered by the Apache license. 3/ NOTICE > I don't see a notice of the included JRuby file (as noted at the bottom > of the LICENSE file). Is this the glassfish line?. We should fix this for 1.0, but it was like this for 0.90 and 0.91 and the copyright is actually referenced in the LICENSE file so i don't think its a blocker for this release. I'll go fix it in the trunk and 0.99 branch. If the answer to these three questions is yes then I'm +1 for going with RC2 > > I've looked mainly at the binary release as follows and made notes of > fixes > required for future reference. If we can go with this RC then, from below, > I > suggest we > > remove helloworld-ws-sdo-webapp > remove helloworld-ws-service-webapp > remove DISCLAIMER/LICENSE/NOTICE files from alert-aggregator > remove Tuscany/Distros/0.99/tuscany-sca-0.99-incubating > > /samples/calculator-webapp-ws/src/test/java/calculator/CalculatorTestCaseOFF.java > > ===================================================================== > > Heres the detail of what I looked at if people want to look at different > things. > > Binary release on Windows > ===================== > Windows XP SP2 > IBM JDK5 > Ant 1.7.0 > > > RAT > !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating-src > /demos/alert-aggregator/src/main/webapp/service.smd > assume can't have it in > !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating-src > /demos/alert-aggregator/src/main/webapp/sources.smd > assume can't have it in > !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating > > /samples/calculator-webapp-ws/src/test/java/calculator/CalculatorTestCaseOFF.java > empty in distribution - remove > !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating > /samples/osgi-supplychain/src/main/resources/osgi/Customer.mf > assume can't have it in > !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating > /samples/osgi-supplychain/src/main/resources/osgi/Retailer.mf > assume can't have it in > !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating > /samples/osgi-supplychain/src/main/resources/osgi/Shipper.mf > assume can't have it in > !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating > /samples/osgi-supplychain/src/main/resources/osgi/Warehouse.mf > assume can't have it in > !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating > /samples/osgi-supplychain/src/main/resources/osgi/ds/Customer.mf > assume can't have it in > !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating > /samples/osgi-supplychain/src/main/resources/osgi/ds/Retailer.mf > assume can't have it in > !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating > /samples/osgi-supplychain/src/main/resources/osgi/ds/Shipper.mf > assume can't have it in > !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating > /samples/osgi-supplychain/src/main/resources/osgi/ds/Warehouse.mf > > CHANGES > Typo running -> running > Add lazy loading of extensions > > DISCLAIMER > OK > > INSTALL > Wrong version number > > LICENSE > Shouldn't all the tuscany modules be listed against the Apache2 license > > NOTICE > Shouldn't a JRUby notice be here also (or is this the glassfish line?). > It > is included at the bottom of the LICENSE files > > README > OK > > RELEASE_NOTES > OK > > Samples > ------- > README > Sample/demo lists don't match what we are delivering > We should recommend maven 2.0.5 not 2.0.6 > Doesn't talk about havng to manually build the war samples > binding-echo > ant run - ok > ant compile run - ok > binding-echo-extension > ok > binding-notification-broker > not tried > binding-notification-consumer > not tried > binding-notification-producer > not tried > calculator > ant run - ok > ant compile run - ok > calculator-distributed > ant run - ok > ant compile run - ok > not ending when enter pressed > calculator-rmi-reference > ant run - ok > calculator-rmi-service > ant run - ok > calculator-script > ant run - ok > calculator-webapp > Ok > calculator-webapp-ws > README > build instruction has wrong sample name > Url is wrong > http://localhost:8085/sample-calculator-webapp/calc.jsp should be > http://localhost:8080/sample-calculator-webapp-ws/calc.jsp > > chat-webapp > No diagram > OK > databinding-echo > ant run - ok > feed-aggregator > ant run - ok > No diagram > helloworld-dojo > Ok > helloworld-jsonrpc > Ok > helloworld-ws-reference > OK > helloworld-ws-sdo > Ok > helloworld-ws-sdo-webapp > No README > No Diagram > ant package > Fails - still some dependency problem > Remove > helloworld-ws-service > Ok > diagram is duff > helloworld-ws-service-webapp > no diagram > README needs text > ant package > Fails > Remove > implementation-composite > ok > implementation-crud > Ok > implementation-crud-extension > Ok > implementation-notification > implementation-pojo-extension > Ok > osgi-supplychain > README is html? > no diagam > ant run doesn't do anything > did something without error but not sure if it did the right thing > simple-bigbank > Ok > simple-bigbank-spring > Ok > simple-callback > Ok > Diagram is duff > simple-callback-ws > Ok > Diagram is duff > supplychain > Ok > Diagram is duff > web-resource > Ok > No diagram > > > Demos > ----- > alert-aggregator > Has DISCLAIMER/LICENSE/NOTICE files? -remove > > bigbank-account > README says use maven to build but ant now works also > README doesn't mention that you have to build them first > ant > bigbank-calculator > No README > ant compile > ant run > bigbank-stockquote > No README > ant compile > ant run > mortgage-creditcheck > Output doesn't match READMe as using Jetty not Tomcat (I think) > Ok > mortgage-loanapproval > Ok > > Src > === > !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating-src > /demos/alert-aggregator/src/main/webapp/service.smd > assume can't have it in > !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating-src > /demos/alert-aggregator/src/main/webapp/sources.smd > assume can't have it in > !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating-src > /distribution/src/main/release/CHANGES > OK > !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating-src > /distribution/webapp/src/main/webapp/sca-contributions/safeToDelete.tmp > Remove? > !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating-src > /itest/databindings/common/src/main/resources/wsdl/Dummy.txt > Remove? > !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating-src > /itest/databindings/common/src/main/resources/xsd/datagraph.xsd > SDO > !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating-src > /itest/databindings/common/src/main/resources/xsd/sdoJava.xsd > SDO > !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating-src > /itest/databindings/common/src/main/resources/xsd/sdoModel.xsd > SDO > !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating-src > /modules/contribution-impl/src/test/resources/test.ext > Empty - remove? > !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating-src > > /modules/implementation-script/src/main/java/org/apache/tuscany/sca/implementation/script/engines/TuscanyJRubyScriptEngine.java > Sun > !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating-src > /modules/implementation-spring/src/main/resources/META-INF/spring.handlers > assume can't have it in > !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating-src > /modules/implementation-spring/src/main/resources/META-INF/spring.schemas > assume can't have it in > !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating-src > > /samples/calculator-webapp-ws/src/test/java/calculator/CalculatorTestCaseOFF.java > Empty - remove > !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating-src > /samples/osgi-supplychain/src/main/resources/osgi/Customer.mf > assume can't have it in > !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating-src > /samples/osgi-supplychain/src/main/resources/osgi/Retailer.mf > assume can't have it in > !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating-src > /samples/osgi-supplychain/src/main/resources/osgi/Shipper.mf > assume can't have it in > !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating-src > /samples/osgi-supplychain/src/main/resources/osgi/Warehouse.mf > assume can't have it in > !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating-src > /samples/osgi-supplychain/src/main/resources/osgi/ds/Customer.mf > assume can't have it in > !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating-src > /samples/osgi-supplychain/src/main/resources/osgi/ds/Retailer.mf > assume can't have it in > !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating-src > /samples/osgi-supplychain/src/main/resources/osgi/ds/Shipper.mf > assume can't have it in > !????? /Tuscany/Distros/0.99/tuscany-sca-0.99-incubating-src > /samples/osgi-supplychain/src/main/resources/osgi/ds/Warehouse.mf > assume can't have it in > > > Bin Release on Linux > ================= > > FC 6 > IBM JDK 5 > Ant 1.7.0 > > Signatures > ---------- > apache-tuscany-sca-0.99-incubating.tar.g.asc > OK > > Samples > ------- > README > binding-echo > ant run - OK > > We need to check the access rights on the repo artifacts but they weren't > there when went through this. >
