[ http://issues.apache.org/jira/browse/TUSCANY-232?page=comments#action_12378718 ]
Scott Kurz commented on TUSCANY-232: ------------------------------------ So I can see that the rework of HelloWorld WS Client which has already bee done goes a long way towards making the client more comprehensible. After the rework we use a client module with only an external service and with no component, so the client-side "HelloWorldService" no longer gets in the way. (I wonder if the original reason for using the client proxy service was due to a bug or then-unimplemented feature in the Tuscany code). I'm not sure if this was done in JIRA-268 or when exactly. All that remains of my comment is: 1) to use a name like "HelloWorldExternalService" in the locateService call, (and to match this in sca.module) 2) use a URL like: "http://localhost:8080/helloworldws-SNAPSHOT/services/HelloWorldServiceEntryPoint"; So I will go ahead and post this. However , I'm realizing that HelloWorld WS seems to have gone away. Does anyone know when it will settle down? I see in JIRA-268 we've moved to the sca/samples directory but I'm not sure what happened to HelloWorld WS. Now that the client proxy is gone, I don't think the remaining items are nearly as confusing, (and arguably don't even need to be done). However, once HelloWorld WS is settled down I'll post updates to both HelloWorldWSClient and HelloWorldWS and let the list decide how/if to use them. > It would be educational to provide a flavor of the HelloWorld WS / HWWS > Client sample which used different names in different contexts where the name > "HelloWorldService" is used today > --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- > > Key: TUSCANY-232 > URL: http://issues.apache.org/jira/browse/TUSCANY-232 > Project: Tuscany > Type: Improvement > Components: Java SCA Samples > Versions: M1 > Environment: Any > Reporter: Scott Kurz > Assignee: Jean-Sebastien Delfino > Fix For: M1 > > A confusing aspect of the HelloWorld WS sample is the fact that certain > strings are repeated > in different contexts. For example, looking at "HelloWorld WS Client", one > can see four > distinct usages of the string, "HelloWorldService". > 1. It is the name of the client-side SCA service, which is invoked by the > HelloWorldClient main() program. > 2. It is the type of the reference variable used in > HelloWorldServiceComponentImpl to invoke the ES over the WS binding > 3. It is the name of the externalService appearing in sca.module: > <externalService name="HelloWorldService"> > 4. It appears in the client-side WSDL URL in order to match the deployment > location of the EP-side Hello World WS WAR > <wsdlsoap:address > location="http://localhost:8080/helloworldws-SNAPSHOT/services/HelloWorldService"/> > It is certainly instructive that you can overload the string in this way. > However, it is at the same time confusing to a completely new user as he has > to sort out which appearances of the "HelloWorldService" string need to stay > in synch with which other uses, and which do not. > It might be educational to also provide a flavor of the HelloWorld WS sample > in which distinct names are used in each of these four locations, > e.g.: > HelloWorldClientService > HelloWorldWSInterface > HelloWorldES > HelloWorldService > Another alternative would be to include in the documenation and exercise > instructing the user to do just this. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
