Jim, Couple notes about your checkstyle commit..... (I know it's still early and you are just beginning to add it, but reviews are good anytime. :-)
1) You shouldn't need to put the tuscany-checkstyle.xml file into each directory. The purpose of the "buildtools" module is to create a jar that holds that file which we can then "depend" on in the other places it's needed. The checkstyle plugin should then be able to pull it from that jar. This method of doing it was taken from the maven checkstyle tips: http://maven.apache.org/plugins/maven-checkstyle-plugin/tips.html 2) Also, I had put it "top level" (in java, not sca) as I thought it would make sense to eventually get the ENTIRE tuscany project on one set of rules, including the specs and SDO projects. Not a huge deal though. I was just hoping to foster a more "across the entire tuscany project" type of thing. 3) The pmd plugin config could also be pushed into the pluginManagement section of the top pom. It would make for less copy/paste into each sub-pom. Actually, if it wasn't for eclipse, the .ruleset file could go into the buildtools module as tuscany-ruleset.xml and sucked in from there like checkstyle. I have a "workaround" for the eclipse issue by creating a special "mvn -Psetup.eclipse" profile that would need to be used instead of "mvn eclipse:eclipse". Not sure we want that though. (basically, the profile would suck the tuscany-pmd-ruleset.xml file out of the buildtools jar and create the .ruleset on the fly. It can also create the .pmd and .checkstyle files on the fly so they aren't checked in in every directory. ) OK, A few notes, not a couple. :-) Nice job though. I'm glad to see the code becoming a bit cleaner and more consistent. Enjoy! -- J. Daniel Kulp Principal Engineer IONA P: 781-902-8727 C: 508-380-7194 F:781-902-8001 [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
