Hi,
Jeremy raised a good question to check if we can avoid the "encode" twice.
I'm not sure if we can tell if the string is encoded or not just by parsing
the string itself. For example, I cannot tell "A%20B" is encoded from "A B"
or not because "%" is encoded as "%25".
Thanks,
Raymond
----- Original Message -----
From: "Jeremy Boynes" <[EMAIL PROTECTED]>
To: <[email protected]>
Sent: Saturday, July 15, 2006 10:28 AM
Subject: Re: [PATCH] Chianti launcher cannot boot from a jar file whose path
contains spaces
On Jul 15, 2006, at 9:15 AM, Raymond Feng wrote:
I tried with both SUN and IBM JDK and got the same problem. To reproduce
it, you can just go to "<chianti>\sca\samples\calculator" and run "mvn".
Running "mvn" from "<chianti>" is successful since it uses the jar from
"<chianti>\sca\core\target" instead of local maven repository.
Ah, that's why I wasn't seeing it. I ran the test from "chianti" and the
standalone launcher from the command line (where the JRE does encode the
URL correctly).
Here is the printout of JarLocation: file:/C:/Documents and
Settings/zfeng/.m2/repository/org/apache/tuscany/core/1.0-chianti-
SNAPSHOT/core-1.0-chianti-SNAPSHOT.jar. Please note the space is from
the maven repository folder.
I think the real problem here lies with maven not creating a well formed
URL to pass to surefire's IsolatedClassLoader - garbage in, garbage out
;-)
I would guess they are using File.toURL() which does not encode as
opposed to File.toURI().toURL() which does - at least that appears to be
what's in SurefireBooter.createClassLoader(). I opened MSUREFIRE-148 for
this.
However, given maven may not be the only thing that is borked perhaps we
should go ahead and encode it.
--
Jeremy
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
