I've committed Jervis' patch (thanks Jervis!) in 426629. I made some formatting changes to pass checkstyle and pmd and have the following comments:

- Axis2Reference and Axis2Service take WebServiceBinding - can we not have it do that? We should decouple the model from the runtime artifacts and I noticed WebServiceBinding gets passed around a bit at the runtime layer when only a few configuration elements are needed.

- Rename WebServiceEntryPointServlet and WebServiceEntryPointInOutSyncMessageReceiver to something like "WebServiceReferenceServlet" and "WebServiceReferenceInOutSyncMessageReceiver" respectively so they correspond to the new SCA naming scheme.

- We should think about introducing monitoring in the axis servlets. Right now they throw ServletException but it would be good to have this picked up by Tuscany runtime monitoring as well

- This has been mentioned but I thought I would add it to the list: WebServiceEntryPointInOutSyncMessageReceiver, Axis2TargetInvoker, Axis2Reference should take the data transformation service, not SDODataBinding

- Should initServlet() and createAxisService(WebServiceBinding wsBinding) in Axis2Service be done by the builder? Related, maybe Axis2Service should not take ServletHost but instead have the builder perform the registration? We may be able to genericize Axis2Service if we do this.

- We should think about handling async and callbacks - and probably should start a separate thread.

Thanks again Jervis.

Jim



On Jul 26, 2006, at 9:07 PM, Jervis Liu (JIRA) wrote:

     [ http://issues.apache.org/jira/browse/TUSCANY-575?page=all ]

Jervis Liu updated TUSCANY-575:
-------------------------------

    Attachment: binding.axis2.rar

As this is a new directory, you may find it handy if you just untar the attached rar and add it into svn sca/bindings directory.

Port Axis2 binding to main trunk
--------------------------------

                Key: TUSCANY-575
                URL: http://issues.apache.org/jira/browse/TUSCANY-575
            Project: Tuscany
         Issue Type: New Feature
         Components: Java SCA Axis Binding
           Reporter: Jervis Liu
        Attachments: binding.axis2.rar, jira575.patch




--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/ Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/ software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to