Thanks! ...ant
On 10/11/06, Bert Lamb <[EMAIL PROTECTED]> wrote:
I'll have a go at fixing it. I noted it as a potential problem when I did the port. I'll have a look at the ServletHost modifications as they seem like they could be useful to everyone. -Bert On 10/11/06, ant elder <[EMAIL PROTECTED]> wrote: > If we're happy with this fix for now would you, or Bert (who did the binding > port to M2), or anyone else be interested in submitting a patch to fix the > jsonrpc binding? I'm happy to do it if not but if any of you are interested > in getting some committership brownie points this type of thing will help :) > I'd be happy to give you what ever help you need. I've created JIRA > TUSCANY-822 for this, I would like to get it fixed for M2 though so there's > not so much time. > > ...ant > > On 10/11/06, ant elder <[EMAIL PROTECTED]> wrote: > > > > Its true that would be an issue if individual services within composites > > could be stopped, but they can't so I don't think this is an issue. Starting > > and stopping works at the composite level not the service or reference > > level. > > > > ...ant > > > > On 10/11/06, Peter Cousins <[EMAIL PROTECTED]> wrote: > > > > > > I am not sure if this is currently supported in the framework overall > > > (if not, it should be), but if I have service A register as with a json-rpc > > > binding, and then service B registers with json-rpc, and then service B > > > unregisters, the servlet would be gone and service A wouldn't function > > > properly anymore…PC > > > > > > > > > ------------------------------ > > > > > > *From:* ant elder [mailto:[EMAIL PROTECTED] > > > *Sent:* Tuesday, October 10, 2006 6:10 PM > > > *To:* Peter Cousins; [email protected] > > > *Subject:* Re: JSON-RPC binding > > > > > > > > > > > > Could always call unregister. UnregisterMapping doesn't throw any > > > exception right now if nothing is registered, maybe we should change it to > > > return whatever was registered so if it was important to the caller to know > > > if anything was registered then it could test for a null return. > > > > > > ...ant > > > > > > On 10/10/06, *Peter Cousins* <[EMAIL PROTECTED]> wrote: > > > > > > That's a good way except how to you know when to unregister? > > > > > > -----Original Message----- > > > From: [EMAIL PROTECTED] [mailto: [EMAIL PROTECTED] ] On Behalf Of > > > ant > > > elder > > > Sent: Tuesday, October 10, 2006 4:53 PM > > > To: [email protected] > > > Subject: Re: JSON-RPC binding > > > > > > How about adding an isMappingRegistered(String mapping) method to > > > ServletHost and then only registering the servlet if its not already > > > registered? > > > > > > ...ant > > > > > > On 10/10/06, Peter Cousins <[EMAIL PROTECTED]> wrote: > > > > > > > > There is a bug in JSONRPCService.java on line 45 where it calls > > > > servletHost.registerMapping("/SCA/scripts", new > > > ScriptGetterServlet()); > > > > > > > > If you have more than 1 service with a json-rpc binding in your > > > > application, this registration throws an exception. One way to fix it > > > > is to add: > > > > > > > > private static final ScriptGetterServlet ScriptGetterServlet = new > > > > ScriptGetterServlet(); > > > > private static int ServletRegistrationCount = 0; > > > > > > > > make start and stop synchronized methods and use reference counting, > > > > e.g., > > > > > > > > in > > > > public synchronized void start() > > > > -------------------------------- > > > > if (ServletRegistrationCount == 0) { > > > > servletHost.registerMapping("/SCA/scripts", ScriptGetterServlet); > > > > } > > > > ServletRegistrationCount++; > > > > > > > > in > > > > public synchronized void start() > > > > -------------------------------- > > > > ServletRegistrationCount--; > > > > if (ServletRegistrationCount == 0) > > > > servletHost.unregisterMapping("/SCA/scripts"); > > > > > > > > Thanks...PC > > > > > > > > -----Original Message----- > > > > From: [EMAIL PROTECTED] [mailto: [EMAIL PROTECTED] On Behalf Of > > > Bert > > > > Lamb > > > > Sent: Monday, September 25, 2006 10:06 AM > > > > To: [email protected] > > > > Subject: Re: [jira] Closed: (TUSCANY-671) Port JSON-RPC binding from > > > M1 > > > > > > > > I'm currently working on making the JSON-RPC binding a little more > > > > Dojo friendly by making it expose a SMD url for bound services. > > > > > > > > I also plan on looking further into a JSON-RPC reference binding. If > > > > anyone has any other suggestions, I'm all ears. > > > > > > > > -Bert > > > > > > > > On 8/31/06, ant elder <[EMAIL PROTECTED]> wrote: > > > > > Thanks again for this Bert. Are you interested in helping continue > > > > > development in this area? There's a lot we could look at doing with > > > > json and > > > > > ajax so if you're interested I'll start some discussion threads. > > > > > > > > > > ...ant > > > > > > > > > > On 8/31/06, ant elder (JIRA) < [email protected]> wrote: > > > > > > > > > > > > [ http://issues.apache.org/jira/browse/TUSCANY-671?page=all ] > > > > > > > > > > > > ant elder closed TUSCANY-671. > > > > > > ----------------------------- > > > > > > > > > > > > Resolution: Fixed > > > > > > > > > > > > Applied. Many thanks for the code Bert. > > > > > > > > > > > > > Port JSON-RPC binding from M1 > > > > > > > ----------------------------- > > > > > > > > > > > > > > Key: TUSCANY-671 > > > > > > > URL: > > > > http://issues.apache.org/jira/browse/TUSCANY-671 > > > > > > > Project: Tuscany > > > > > > > Issue Type: Improvement > > > > > > > Components: Java SCA JsonRpc Binding > > > > > > > Affects Versions: Java-M2 > > > > > > > Reporter: Bert Lamb > > > > > > > Assigned To: ant elder > > > > > > > Priority: Minor > > > > > > > Attachments: json-rpc-binding.zip > > > > > > > > > > > > > > > > > > > > > Port the JSON-RPC binding from M1 into the new binding format. > > > > I've > > > > > > been working on this, so I should be able to post a patch soon. > > > > > > > > > > > > -- > > > > > > This message is automatically generated by JIRA. > > > > > > - > > > > > > If you think it was sent incorrectly contact one of the > > > > administrators: > > > > > > http://issues.apache.org/jira/secure/Administrators.jspa > > > > > > - > > > > > > For more information on JIRA, see: > > > > http://www.atlassian.com/software/jira > > > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > > > > > > > > > > > > > >
