Hi Luciano, Some comments in line ...
Luciano Resende wrote:
Thanks Kevin, some comments below...
As for the naming :) I was just calling DAS exposed as an SCA service...
On 11/8/06, Kevin Williams < [EMAIL PROTECTED]> wrote:
The term DAS-POJO Service is probably confusing. What I meant is
service implemented in Java that does not require a new component type.
POJService?
--
Kevin
Kevin Williams wrote:
> I just committed the nice DAS - POJO service contribution from Luciano
> and have a few comments/discussion points:
>
> Here is the service API:
>
> /**
> *
> * @author lresende
> *
> */
> public interface DASService {
> public void configureService(InputStream configStream)
> throws
> DASServiceException;
> public DataObject executeCommand(String commandName,
Vector
> commandArguments) throws DASServiceException;
> public DataObject execute(String adHocQuery, Vector
> commandArguments) throws DASServiceException;
>
> public void applyChanges(DataObject graphRoot) throws
> DASServiceException;
> }
>
>
>
> We need to find a way to replace the "configureService" API with an
> SCA pattern for providing config information.
Yes, this was THE thing I know we need to improve as mentioned on this
thread :
http://www.mail-archive.com/tuscany-dev%40ws.apache.org/msg10421.html
SCA guys, any suggestions about something already available in SCA ? Or
maybe an Annotation ?
Rick has mentioned the use of a "property" in the SCDL to reference the
DAS Config file. Sounds like this would work!
Amita has solved this with the DAS-container contribution but I assume
there is a pattern
> for POJO services too.
>
> We should avoid checked exceptions.
>
Could you elaborate little bit more here ? Why exactly this ?
DAS has avoided the use of checked exceptions. IMHO, they are more
trouble then they are worth. So, it is really just to continue that
convention.
Could the Vector argument list be replaced with a List?
>
> I think Apache discourages the use of the @author tag
Sure, it was just a setting in my eclipse IDE, I'll create a patch
removing
that.
As for the other things... I'll look into that and provide a patch
with the
changes...
> --
> Kevin
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
