Hi, Lee.

Thank you very much for the review. Please see my comments below.

Raymond

----- Original Message ----- From: "Lee Surprenant" <[EMAIL PROTECTED]>
To: <[email protected]>
Sent: Tuesday, November 14, 2006 8:25 AM
Subject: Review of Tuscany Java M2 Samples/Readme


After yesterday's chat I took some time to look at the samples/readmes from
the M2 branch.  Minus a few grammatical mistakes, I found the content
consistent and easy to follow.  Here are a few minor questions/concerns:

  - Why is the core-1.0-incubator-M2-SNAPSHOT.jar included in the
  contrib dir?

It was brought in by a dependency with wrong scope (test instead of compile) and I fixed it.

  - Are the runtime property (-D) options documented somewhere?  It took
  me a while to find -Doffline=true for the standalone runtime.

I'll find a place for this :-)

  - The BigBank Sample Location section of the readme incorrectly states
  that BigBank is located in the sampleapps/bigbank dir.

Fixed.

  - When I try to run mvn tomcat:deploy on
sample-helloworldjsonrpc.warfrom eclipse, I obtain the following
error: LifecycleExecutionException: No
Java test frameworks found. The command works fine from terminal. Strange
  because I can deploy all the other samples from eclipse.

Need some investigation.

  - Why are binding.axis2.scdl and databinding.sdo.scdl included at
  sca/runtime/webapp-host/src/main/resources/META-INF/sca/?

I'll check.

  - It seems unclear/confusing to me to include the outdated documents
  at tuscany-sca-1.0-incubator-M2-src\src\sca\doc in the source distro.


The docs are now removed from the distro. And will see if we can make them updated for the web site.

thanks,

-Lee



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to