[ http://issues.apache.org/jira/browse/TUSCANY-921?page=all ]

Venkatakrishnan updated TUSCANY-921:
------------------------------------

    Attachment: Tuscany-JIRA-921-15-Nov-2006.diff

Hi Jim

I have attached a patch for this for a quick review from you.  Right at the 
onset let me submit that there are not unit tests done since I am only trying 
to check if I have got this right in the first place.  If found ok, I will fill 
up the testcases and only then commit.  

Having said that if you are wondering if I ever tested this - YES I have done 
so.  I tried running the tests under RMI and JavaScript extensions after 
modifications to the scdls there and they work.  These modifications are also a 
part of the attached patch.

Here are some questions / thoughts behind this implementation:-
1) I find that the specs does not say anything specific about composite 
services MUST having a target defined inline as a reference.  Infact there is a 
sample that has all wired defined outside a service definition by using 'wire' 
elements.  But then our ServiceLoader implementation insists on a target to be 
defined inline as part of a composite's service.   I have changed this in this 
patch.

2)  There is a possibility that targets are defined inline and then there is 
also an explicit wire element that is defined.  In such cases which of them 
overrides the other.  Do we override what is there defined inline with what 
gets to be defined in the 'wire' elements?  The specs says nothing about this 
as far as I have seen.

Thanks.

- Venkat




> <wire> element in SCDL causes UnrecognizedElementException
> ----------------------------------------------------------
>
>                 Key: TUSCANY-921
>                 URL: http://issues.apache.org/jira/browse/TUSCANY-921
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SCA Core
>    Affects Versions: Java-Mx
>            Reporter: Greg Dritschler
>         Assigned To: Venkatakrishnan
>         Attachments: Tuscany-JIRA-921-15-Nov-2006.diff
>
>
> Using a <wire> element in a composite results in an exception.
> org.apache.tuscany.spi.loader.UnrecognizedElementException: 
> {http://www.osoa.org/xmlns/sca/1.0}wire
> [{http://www.osoa.org/xmlns/sca/1.0}wire]
> Context stack trace: [application]
>         at 
> org.apache.tuscany.core.loader.LoaderRegistryImpl.load(LoaderRegistryImpl.java:90)
>         at 
> org.apache.tuscany.core.implementation.composite.CompositeLoader.load(CompositeLoader.java:81)
>         at 
> org.apache.tuscany.core.implementation.composite.CompositeLoader.load(CompositeLoader.java:55)
>         at 
> org.apache.tuscany.core.loader.LoaderRegistryImpl.load(LoaderRegistryImpl.java:92)
>         at 
> org.apache.tuscany.core.loader.LoaderRegistryImpl.load(LoaderRegistryImpl.java:109)
>         at 
> org.apache.tuscany.core.implementation.composite.CompositeComponentTypeLoader.loadFromSidefile(CompositeComponentTypeLoader.java:65)
>         at 
> org.apache.tuscany.core.implementation.composite.CompositeComponentTypeLoader.load(CompositeComponentTypeLoader.java:57)
>         at 
> org.apache.tuscany.core.implementation.composite.CompositeComponentTypeLoader.load(CompositeComponentTypeLoader.java:39)
>         at 
> org.apache.tuscany.core.loader.LoaderRegistryImpl.loadComponentType(LoaderRegistryImpl.java:159)
>         at 
> org.apache.tuscany.core.deployer.DeployerImpl.load(DeployerImpl.java:101)
>         at 
> org.apache.tuscany.core.deployer.DeployerImpl.deploy(DeployerImpl.java:76)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to