On Nov 21, 2006, at 5:11 AM, ant elder wrote:
Sure I'm willing to help :) I wasn't sure of the state of the M2
branch and
the code freeze so didn't want to just go ahead committing changes
without
mentioning them here first. Most of the things I mentioned are
probably not
blockers so wouldn't get -1s if we just went ahead and did the
release as
is. What do you think as RM, in your opinion are any of these valid
and
needing to be changed for M2?
I think I'm a similar mindset as you - that there could be some
tweaks to improve things but not compelling enough that they /have/
to be done.
> A few review comments of these latest distro downloads:
>
> - The distro's unzip into varying directories, the standalone
> distro into
> the current directory, the src into a directory named src, samples
> into a
> directory named src etc. This should be consistent and be to a top
> level
> directory named tuscany-m2-xxx (or apache-tuscany-m2-xxx)
>
Agreed on consistency but to be consistent with the other M2 releases
I don't think we should change this right now but hold off until the
next release.
> - Not all the distro's include the LICENSE and NOTICE files in the
> top level
> directory, they are included but in a nested sub directory.
>
This should be in the root but we're exporting trees with prefixes
(just not the tuscany-* ones). If the have the files in the effective
root of the distro then I think we're OK.
> - What was the decision on mentioning the NPL license? The binary
> distro
> doesn't mention it in the LICENSE/NOTICE files now, the src and
> samples
> distro still do.
You're the scripting guy :-) AIUI we never redistribute Rhino and so
have no work under the NPL so this should be removed.
>
> - Binary distro NOTICE file includes licenses, should these be
> moved to
> the LICENSE file?
Can you please be more specific? Some of the libraries require parts
of the license to be included in a notice and that may be what you
are seeing.
>
> - Is there a list of jars that are going to go in the maven
> repository so we
> can review them? For example if the launcher.jar goes in a maven
> repo should
> it be named launcher-incubator-M2.jar
I don't have such a list - compiling it would be helpful as we will
need to point to these in the vote.
>
> - Should all the names -incubator- be renamed to -incubating- to
match
> recent incubator general mailing list discussion (this could be
> left as a M3
> action)
For consistency with the other M2 releases I don't think we should
change this now.
>
> - Should there be something like a readme or release notes in top
> level
> directory of each distro? Some of the distros do have this (eg
> samples and
> spec) the others don't include one.
>
> - The spec distro README.txt talks about the old M1 (May 2006)
release
>
> - All the Tuscany jars still include M2-SNAPSHOT, is -SNAPSHOT
> going to be
> removed for the release candidate
Yes
>
> - None of the samples build anymore for me when running mvn in the
> sample
> directory(mvn in the top level samples directory works)
>
> [ERROR] FATAL ERROR
> [INFO]
> ----------------------------------------------------------------
> [INFO] Failed to resolve artifact.
>
> GroupId: org.apache.tuscany.sca.samples
> ArtifactId: parent
> Version: 1.0-incubator-M2-SNAPSHOT
>
> Reason: Unable to download the artifact from any repository
>
> org.apache.tuscany.sca.samples:parent:pom:1.0-incubator-M2-
SNAPSHOT
>
Looks like the samples' parent pom wasn't published - I'll do that.
--
Jeremy
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
