Thanks for the patch. We'll apply it and test it asap.
Cheers, On 22/11/06, Yang ZHONG <[EMAIL PROTECTED]> wrote:
http://issues.apache.org/jira/browse/TUSCANY-946 to track separatly, although 563 work was the originator. On 11/21/06, Yang ZHONG <[EMAIL PROTECTED]> wrote: > > http://issues.apache.org/jira/browse/TUSCANY-563 > > Thanks. > > > On 11/21/06, Pete Robbins <[EMAIL PROTECTED]> wrote: > > > > On 21/11/06, Yang ZHONG <[EMAIL PROTECTED]> wrote: > > > > > > Thanks a lot to Pete and Geoff. > > > Here's an optimization incorporated with their feedback: > > > > > > > > > SDOString& DataFactoryImpl::getFullTypeName(SDOString& stringBuffer, > > > const char* uri, const char* inTypeName) const > > > //TODO: getFullTypeName is private, change it accordingly when API > > such as > > > addType signature start to use "const SDOString&" which is safer than > > > "const > > > char*" > > > { > > > stringBuffer = uri; > > > stringBuffer += "#"; > > > return stringBuffer += inTypeName; > > > } > > > void DataFactoryImpl::addType(const char* pccUri, const char* > > > pccTypeName,...) > > > { > > > SDOString fullTypeName; > > > getFullTypeName(fullTypeName, pccUri, pccTypeName); > > > ... > > > } > > > > > > Much more importantly, we want to consider &, *, += and so on, while > > using > > > an object. > > > > > > -- > > > > > > Yang ZHONG > > > > > > > > That looks good. Do you want to raise a Jira and create a patch for > > this? > > > > Cheers, > > > > -- > > Pete > > > > > > > -- > > Yang ZHONG -- Yang ZHONG
-- Pete
