On Nov 24, 2006, at 12:14 AM, ant elder wrote:
On 11/23/06, Jim Marino <[EMAIL PROTECTED]> wrote:
<snip>
When doing a checkin, please remember to run mvn -Psourcecheck.
The last time we talked about this the decision was that the
checkstyle
rules were going to be relaxed to match the IDE formatter templates
that
Raymond was going try to make compatible, and only then were we
going to
look at making sourcecheck mandatory. That's not happened yet and the
current sourcecheck rules are quite incompatible with what the IDE
formatters produce.
That's really not painting an accurate picture. For the most part,
unless I am mistaken, they are very compatible, including Eclipse,
outside of a few things such as array indentation which can easily be
fixed by hand. With IntelliJ, I have never had any problem. But more
to the point, I had to fix PMD violations, which are not a matter of
style but denote problematic and error-prone code. We've had the
debate about code format and PMD checking on several occasions
spanning months and I would like to put it to rest. Specifically, I
would like to address your issues so we can do so. I'm assuming you
do not have problems with the actual code formating rules as those
were mostly agreed to at the outset of the project. However, if you
do, could you please point out which ones? Are you philosophically
against using checkstyle and PMD? Other questions:
1. Could you please identify which issues you are having with the
Eclipse template? My understanding is there are only a few edge cases
where it does not format correctly. The one I know about (array
indentation), only happens in one class in the codebase,
org.apache.tuscany.spi.databinding.extension.XSDDataTypeConverter
(the array Base64Binary). There may be a few more minor issues
somewhere but I have not run into them.
2. Which PMD rules do you have issues with?
Please note that what I and others have been asking is that
committers take care to ensure their code is formatted according to
the guidelines we have set out in the project. This is a courtesy to
other committers as well as anyone reading the code. Sometimes
people (including myself) forget to do this. No big deal, as long as
an effort is made to fix them in a reasonable amount of time.
Raymond is out this week, lets wait till he's back and
see if he was able to make any progress on getting sourcecheck/
eclipse/idea
to all work happily together.
IntelliJ works fine, As an Eclipse user, perhaps you could take a
look at the issues you are encountering so we can get resolution
before Raymond gets back?
Jim
...ant
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
