Do we? I was looking at CompositeComponentType#getComponents and it
does:
for (Include i : includes.values()) {
view.putAll(i.getIncluded().getComponents());
}
which looks like it just drops duplicates.
I think we should check in two places:
1) when adding a component, reference or service to the model that no
other has the same name
2) when merging includes that there are no duplicates across the merge
I don't think the second should be done silently in getComponents()
as that is a bit obscure - better to do an explicit check in the
builder (until that check can be moved to verify).
--
Jeremy
On Jan 23, 2007, at 9:30 AM, Jim Marino wrote:
On Jan 23, 2007, at 9:00 AM, Jeremy Boynes wrote:
Isn't this a problem in the verify/build phase rather than the
loader?
--
Jeremy
We already support this in the build phase. Ultimately this
function would be moved into the verify phase but since we don't
have it yet and the change is minimal, we can get it in and move it
once I get to separating the phases.
Jim
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
