[
https://issues.apache.org/jira/browse/TUSCANY-1091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473128
]
Kelvin Goodson commented on TUSCANY-1091:
-----------------------------------------
Hi Yang,
I'm going to have to push back on a couple of things here, sorry.
First is that I'm getting a test failure when I run in maven (not in eclipse)
the exception stack is ...
Test set: org.apache.tuscany.sdo.test.XMLStreamHelperPerformanceTestCase
-------------------------------------------------------------------------------
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.06 sec <<<
FAILURE!
testDynamic(org.apache.tuscany.sdo.test.XMLStreamHelperPerformanceTestCase)
Time elapsed: 0.03 sec <<< ERROR!
java.lang.NullPointerException
at
org.apache.tuscany.sdo.util.DataObjectUtil.createDataObject(DataObjectUtil.java:476)
at
org.apache.tuscany.sdo.impl.DataObjectImpl.createDataObject(DataObjectImpl.java:1196)
at
org.apache.tuscany.sdo.test.XMLStreamHelperPerformanceTestCase.testDynamic(XMLStreamHelperPerformanceTestCase.java:64)
at
org.apache.tuscany.sdo.test.XMLStreamHelperPerformanceTestCase.testDynamic(XMLStreamHelperPerformanceTestCase.java:64)
....
I'm not sure why line 64 appears twice in the stack, could you take a look
please?
The second thing is again something I'm not sure we have a policy on but I
think is could be confusing. You have introduced a class which differs in name
from the interface it implements only by case.
NameSpaceContext implements NamespaceContext
I think this is potentially confusing. Would you be able to change this to
perhaps a XXXImpl class please.
> DataObjectXMLStreamReader doesn't have to repeat NameSpace declaration which
> impacts performance
> ------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-1091
> URL: https://issues.apache.org/jira/browse/TUSCANY-1091
> Project: Tuscany
> Issue Type: Improvement
> Components: Java SDO Implementation
> Affects Versions: Java-SDO-Mx
> Reporter: Yang ZHONG
> Fix For: Java-SDO-Mx
>
> Attachments: bindLessNS, bindLessNS, simple3.xsd,
> XMLStreamHelper.xsd, XMLStreamHelperPerformanceTestCase.java
>
>
> <p0:quotes3>
> <p1:symbol3
> xmlns:p1="http://www.example.com/simple3";>IBM</p1:symbol3>
> <p1:company3 xmlns:p1="http://www.example.com/simple3";>IBM
> Corp.</p1:company3>
> </p0:quotes3>
> can be optimized as
> <p0:quotes3 xmlns:p1="http://www.example.com/simple3";>
> <p1:symbol3>IBM</p1:symbol3>
> <p1:company3>IBM Corp.</p1:company3>
> </p0:quotes3>
> Thanks to Fuhwei Lwo for prototyping the Test Case. I've made small changes
> to make use of HelperContext so that it will neither interfere nor be
> interfereed by other build test(s).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
