[
https://issues.apache.org/jira/browse/TUSCANY-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489977
]
Kelvin Goodson commented on TUSCANY-1181:
-----------------------------------------
Dan,
I looked at this again and have decided that svn is, as you suggested,
lacking in the capacity to represent file moves in patch files. (FYI It seems
to reduce the original to zero size and then apply the edits to the newly named
file as if that file already exists in the repository)
Looking at the checkTypes method I think it would be better to iterate over the
schemaTypes ensuring that the SDO environment has a type for each of those. Do
you agree? I think this is more in the spirit of the spec requirement, and
avoids the need to say anything about DocumentRoot in the test. It also caters
for the corner case where the schema contains a type called DocumentRoot.
Unless you can see any reason why not, I'm happy to tweak this methods to take
this approach if you like.
Kelvin.
> XSDSerializationTest is Tuscany-specific
> ----------------------------------------
>
> Key: TUSCANY-1181
> URL: https://issues.apache.org/jira/browse/TUSCANY-1181
> Project: Tuscany
> Issue Type: Bug
> Components: Java SDO Community Test Suite
> Reporter: Andy Grove
> Attachments: Tuscany-1181.patch
>
>
> XSDSerializationTest contains assertions like the following that expect 2
> types to be created from simple.xsd, which just contains a single type called
> "Quote".
> assertEquals("XSDHelper.define() did not create the expected number of
> Types", 2, types.size());
> Presumably the current assertion is based on DocumentRoot being in the types
> list.
> It would be better to check that the "Quote" type is in the list rather than
> just checking the size of the list.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
