On 5/19/07, Jean-Sebastien Delfino <[EMAIL PROTECTED]> wrote:
ant elder wrote: > On 5/19/07, Jean-Sebastien Delfino <[EMAIL PROTECTED]> wrote: >> >> I'd like to do a little bit of cleanup of the new sample modules that >> we've added to better separate the sample extensions and the samples >> showing how to use them. >> >> I'll make the following changes: >> - add missing files and directories to svn:ignore properties >> - move test resources to src/test/resources >> - use different packages for the client code and the extension code >> - rename the composite files to <composite name>.composite as this is >> the convention we've adopted for all other samples >> - change the test cases in implementation-crud-client and >> binding-echo-appl to look like normal test cases (instead of invoking >> the client.main methods) >> >> I'll make these changes in the trunk and will merge them into the 0.90 >> branch. >> >> I'd also like to see better names for these modules: >> - implementation-crud-client is not really a client as it contains the >> CRUD component in addition to a client >> - binding-echo-appl is an application, like the other one it contains a >> client and the component that it invokes, but we've tried to not use the >> term application in the other samples >> - today somebody pinged me to ask me where he could find our extension >> samples, so I'm gathering from it that it's not clear that crud and echo >> are these samples >> >> To address this, I'd like to rename: >> - echo-binding to echo-binding-extension >> - echo-binding-appl to echo-binding >> - implementation-crud to implementation-crud-extension >> - implementation-crud-client to implementation-crud >> >> -- >> Jean-Sebastien > > > When are you going to do this? I was planning to tag and build the > release > RC today (now). > > ...ant > I just made the first set of changes to clean up these modules and will merge them to the branch next. I'm not sure about the second set of changes to rename these sample modules. I'm starting to think that we're over complicating these samples by splitting them in 2 modules for each extension. I preferred when we just had one implementation-crud module and one echo-binding module.
Ok I'll wait till tomorrow to make the RC. IMHO do whatever you think is best for the extension samples ... :) ...ant
