I successfully built the source distribution (including the distribution
module). I reviewed the contents of the binary distribution and I ran
and built all the samples using the instructions in the READMEs.
I have a few minor comments but nothing too serious, so here's my
+1 (non-binding).
Minor comments:
1. Can't build the distribution module unless you are either connected
to the internet or explicitly use the -o option. I'll start a separate
thread to discuss this.
2. Many of the sample README files contain typos. Most are obvious, but
one in samples/README has "now" for "not" and is potentially confusing.
3. samples/calculator/README does not list all the sample files and
has a typo in one of the file names. This filename typo is propagated
to the other calculator samples as well.
4. samples/simple-bigbank/README has an incorrect directory hierarchy.
5. The output from the calculator-script sample included a jython warning
message about a cache directory. This wasn't mentioned in the README.
6. The filenames listed in the READMEs for calculator-rmi-service and
calculator-rmi-reference don't match what's in the samples.
7. The CalculatorClient class in calculator-rmi-service doesn't seem
to be used.
8. samples/helloworld-jsonrpc/README has an incomplete list of file names,
with typos in one of them.
9. I think it would be better the reverse the order of simple-callback
and implementation-composite in the samples/README file. These samples
are supposed to be in order of complexity, but implementation-composite
introduces two new concepts (composite implementations and callbacks).
It would be better to introduce the callback concept in simple-callback
before using it as part of implementation-composite.
10. samples/simple-callback/README has typos in file names.
11. samples/databinding-echo/README has an outstanding "TODO" note.
12. samples/implementation-crud/README has incorrect file list under src/main
(includes crud.composite which has moved to src/test).
13. samples/implementation-crud-client/README has incorrect package names
under src/main and src/test.
14. samples/implementation-crud-client/README refers to a .png file name that
does not match the .png file actually included in this sample.
15. CRUDTestCase in implementation-crud-client is testing the server code
not the client code.
16. Sample test output in samples/implementation-crud-client/README does not
match what is actually produced at runtime (a consequence of 15 above).
17. samples/binding-echo/README has incorrect file list under src/main
(includes EchoBinding.composite which has moved to src/test).
18. samples/binding-echo-appl/README has incorrect composite file name
under src/main/resources.
19. samples/binding-echo-appl/README refers to a .png file name that
does not match the .png file actually included in this sample.
20. Sample application output and sample test output in
samples/binding-echo-appl/README do not match what is actually
produced at runtime.
21. The INSTALL file doesn't mention the README and RELEASE_NOTES files.
I'll write JIRAs for the samples and README problems that I found (to be
fixed in the next release), and I'll create and attach patches for these.
Simon
ant elder wrote:
Please review and vote on the 0.90 release artifacts of Tuscany SCA for
Java.
The artifacts are available for review at:
http://people.apache.org/~antelder/tuscany/0.90-rc2/
This includes the binary and source distributions, the RAT reports, and the
Maven staging repository.
The SVN tag for the release is:
https://svn.apache.org/repos/asf/incubator/tuscany/tags/java/sca/0.90-incubating/
Looks ok to me so here's my +1.
Thanks in advance,
...ant
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
