problem in Input2InputTransformer: if (sourceWrapped && (!targetWrapped))

[Scott Kurz]

In testing some of the issues mentioned in this thread:
http://www.mail-archive.com/tuscany-dev@ws.apache.org/msg18236.html
on some newer code I noticed what seems to be a problem in
Input2InputTransformer


It seems like the targetWrapperHandler can't get set in the case we go down
this path:

 if (sourceWrapped && (!targetWrapped))


Instead of doing:
     targetWrapperHandler = getWrapperHandler(targetDataBinding, false);
we should do this:
     targetWrapperHandler = getWrapperHandler(getDataBinding(targetOp);,
false);
since above we only set 'targetDataBinding' if 'targetWrapped' was true:
      if (targetWrapped) {
           targetDataBinding = getDataBinding(targetOp);
           targetWrapperHandler = getWrapperHandler(targetDataBinding,
true);
       }


Or something equivalent should be done...

This seems too small for a JIRA so I won't open one.

Raymond, do you agree?

Scott