SCADomain. getService () should follow CompositeContext.getService()
conventions for "service-name"
---------------------------------------------------------------------------------------------------
Key: TUSCANY-1354
URL: https://issues.apache.org/jira/browse/TUSCANY-1354
Project: Tuscany
Issue Type: Bug
Affects Versions: Java-SCA-M2
Reporter: Kevin Williams
Fix For: Java-SCA-Next
The current SCADomain method
"public abstract <B> B getService(Class<B> businessInterface, String
serviceName);"
is similar in purpose to the .95 specification for
CompositeContext.locateService API. For this reason, the new API should follow
the conventions established of the old API.
This is from the .95 specification:
public interface CompositeContext {
...
T locateService(Class<T> serviceType, String serviceName);
}
"serviceName" can take on one of the following forms:
<component-name>/<service-name>
If the service-name is not provided, the name of the serviceType sans package
name will be used as the service-name
The current implementation getService ends up in the following code:
public <B> ServiceReference<B> getServiceReference(Class<B> businessInterface,
String name) {
// Extract the component name
String componentName;
String serviceName;
int i = name.indexOf('/');
if (i != -1) {
componentName = name.substring(0, i);
serviceName = name.substring(i + 1);
} else {
componentName = name;
serviceName = null;
}
It seems that the "else" should default serviceName to
businessInterface.getSimpleName() in order to follow the existing convention.
A test case will follow shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
