[
https://issues.apache.org/jira/browse/TUSCANY-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amita Vadhavkar updated TUSCANY-1317:
-------------------------------------
Attachment: 1317.patch
JIRA1317Design.txt
Hi,
1)As the name of JIRA-1317 implies, it is only for load options and not for
save options. So the code changes I am attaching to
1317.patch are only for load options.
Please see the design document attached to the JIRA for detailed changes done.
Questions-
<1>Is there a need to modify CTS for this? or just tuscany-sdo-impl/tests? What
is the standard
convention we follow for SDO Unit Testing?
<2> Also, another doubt on same lines, in SDOXMLResourceImpl.doLoad(), else
for if(options != null) is never
executed(checked all test cases, that this path is never taken), as in
DataObjectUtil.configureXMLResource (), some default
options are always set. So, what is the purpose of having this code?
2)I will create new JIRA for www.mail-archive.com/[EMAIL
PROTECTED]/msg01000.html- with title -
serialize/deserialize extra properties in SDO/XML (using
XMLResource.OPTION_RECORD_UNKNOWN_FEATURE)
Quenstions - When during deserialization, we get 0..n AnyDataObjects for these
extra features/properties, what should be the
design to make space for these? Say, have a new Property (named
"AdditionalProperties") added to root DataObject
and save all the AnyDataObjects (bunched in one DataObject under containment)
against this property? So, when the
caller says doc.getRootObject().getDataObject("AdditionalProperties"), he will
get handle for this?
i.e. in details say,
in XMLDocumentImpl - similar to initLoadedRoot(), have another
method initAdditionalObject() to modify member EObject rootObject to add this
new DataObject?
This is my first JIRA in SDO, and so I may be deviating from the right
approach, so please give me all your suggestions,
naming conventions for new methods, members etc.
3)Shall I created new JIRA-with title-
Provide a way to set default XLM save options to be used during Java
serialization?
We have 12.5 hrs time difference due to our time zones (IST and PDT). I will
try to be online tonight and see if we can chat
for the above, so I can work tomorrow on 2) and 3). I guess, as you will get
the patch today for review, it may be better, if we
can have a scheduled chat tomorrow again, i.e. June 28, 9.30 a.m. PDT, when I
can get my doubts clear for your review comments
on 1) and if possible review 2) and 3).
Thanks and with best regards,
Amita
> Provide a way to set default XML load options to be used during Java
> deserialization
> ------------------------------------------------------------------------------------
>
> Key: TUSCANY-1317
> URL: https://issues.apache.org/jira/browse/TUSCANY-1317
> Project: Tuscany
> Issue Type: New Feature
> Components: Java SDO Implementation
> Affects Versions: Java-SDO-beta1, Java-SDO-1.0
> Reporter: Daniel Peter
> Fix For: Java-SDO-1.0
>
> Attachments: 1317.patch, JIRA1317Design.txt, JIRA_1317_June21.txt,
> JIRA_1317_June25_Amita.txt
>
>
> XML load options can be passed when calling the XMLHelper.load(...) methods.
> But there is currently no way to pass such load options to be used during
> Java deserialization.
> Thus a way to set default load options should be provided, e.g.
> SDOUtil.setDefaultXMLOptions(HelperContext, Object options)
> These default options could then be picked up during Java deserialization,
> i.e. in the method readDataObject in class HelperProviderImpl.ResolvableImpl.
> Additionally the XMLResource.OPTION_RECORD_UNKNOWN_FEATURE option could be
> exposed in Tuscany SDO.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
