[
https://issues.apache.org/jira/browse/TUSCANY-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12517104
]
Adriano Crestani commented on TUSCANY-1464:
-------------------------------------------
Hi Amita,
I reviewed your path and got some questions before commit it:
1 - On method ResultMetadata.getAllPKsForTable(String tableName), I understand
that you return an empty Set when there is no column in config, but why you add
an empty String on it?
2 - On ResultSetProcessor, shouldn't be thrown an exception when the table has
pk but this pk is null instead of just ignoring the row?
3- Sorry, but I didn't get why you added the ID attribute on company.xsd : (
There are other minor issues that I will fix, as it's just for increase the
performance I won't bother you describing them here ; )
Regards,
Adriano Crestani
> Wrong query results when SELECT misses PKs
> ------------------------------------------
>
> Key: TUSCANY-1464
> URL: https://issues.apache.org/jira/browse/TUSCANY-1464
> Project: Tuscany
> Issue Type: Bug
> Components: Java DAS RDB
> Affects Versions: Java-DAS-Next
> Reporter: Amita Vadhavkar
> Assignee: Amita Vadhavkar
> Fix For: Java-DAS-Next
>
> Attachments: 1464.patch
>
>
> http://www.mail-archive.com/[email protected]/msg20322.html
> Fix the bug uncovered in above mail discussion.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
