[
https://issues.apache.org/jira/browse/TUSCANY-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amita Vadhavkar updated TUSCANY-961:
------------------------------------
Attachment: 961.patch
List of files changed:
*1) DAS
-set/get for helperContext
*2)DasFactory
-2 new createDAS() methods accepting helperContext from caller
*3)GraphBuilderMetaData
-new constructor accepting helperContext
-new SDO methods - createType(), getType(), createProperty(), getProperty(),
getTypes()
-using helperContext param improved logic to avoid recreation of existing Types
and Properties improved logic to avoid numerous TypeHelper creation (old DAS
has 1 instance/1 read command)
*4)GraphMerger
-new member vars HelperContext and TypeHelper
-new constructor accepting helperContext from caller
-emptyGraph() - uses new SDO methods - createType(), getType(),
createProperty(), getProperty(), getTypes() using helperContext param
*5)DasFactoryImpl
-impls of 1)
*6)DasImpl
-new member HelperContext, set/get
-DASImpls for 4)
-get/createCommand with setHelperContext() calls.
*7)BaseCommandImpl
-new member helperContext (holds ref from DASImpl), setter/getter
-This approach is followed, so that without DAS, caller can directly set
helperContext in command.
-This way in a scenario, where say there are multiple database schemas involved
in a business case and user wants to keep different contexts in SDO/dbms
schema, he can make sure to pass different context to different commands, based
on the dbms schemas involved..and so forth.
*8)ReadCommandImpl
-new SDOUtil.createDataGraph()
-new GraphBuilderMetadata() passing helperContext from command
*9)UpdateGenerator
-getUpdateCommand() - used new dataObject.getInstanceProperty()
*10)CompanyTests
-testSimpleStatic() - CompanyFactory registered in context
11)ConverterTests
-CustomerFactory register
*12)ExceptionTests
-CustomerFactory, CompanyFactory register
*13)GraphMergeTests
-diff Type Factory register
*14)TopDown
-diff Type Factory register
*15)SimplestStaticCrud
-testRead() - new way to register context in CustomerFactory
*16)AliaseTests
-added new CustomerData() in setUp() already in JIRA 1464 (under review)
*17)ReadCustomersStaticTypesCommand
-CustomerFactory registered in context in new way
*18)ReadCustomersStaticTypesCommand2 - new test case for passing -HelperContext
from caller
*19)GeneratedCommandTests.
-testReadCustomersStaticTypes2() for 19)
*20) new Unit Tests - HelperContextTests
*21) DasTest - superclass of all test cases - in setUp() calls
-HelperProvider.getInstance();
This is required so that each test case gets a clean HelperContext. Otherwise,
places where column converters are used e.g. there will be a conflict in Type
of a column (e.g. Customer.ID is int, but in converter test it is long.)
If SDO JIRA-761 is resolved, this approach can be changed and in
DasTest.setUp(), we can do unregister of required namespaces instead of
creating new instances of HelperProvider.
*22) AllCommonTests -
-include HelperContextTests
*23) sample-ajax-das
-DasQueryProcessor.getRSS() , getConverter()- HelperProvider.getInstance()
added as converters need a clean helper context.
> DAS: Using deprected SDO method causes Type lookup failure
> ----------------------------------------------------------
>
> Key: TUSCANY-961
> URL: https://issues.apache.org/jira/browse/TUSCANY-961
> Project: Tuscany
> Issue Type: Bug
> Components: Java DAS RDB
> Reporter: Brent Daniel
> Assignee: Amita Vadhavkar
> Fix For: Java-DAS-Next
>
> Attachments: 961.patch
>
>
> The DAS is still using SDOUtil.createTypeHelper() rather than
> TypeHelper.INSTANCE. This causes the DAS to not have visibility of types
> defined by TypeHelper or XSDHelper.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
