Hey Andy, It should be OK for you to committ it directly, if you need a review just forward the committ log and ask people to review (but I guess they will be reviewing it anyway from the mail notifications).
On 8/3/07, Adriano Crestani <[EMAIL PROTECTED]> wrote: > Andy, please, check if everything was commited as expected to resolve the > JIRA1397. > > Regards, > Adriano Crestani > > On 8/3/07, Adriano Crestani <[EMAIL PROTECTED]> wrote: > > > > Applyed the new patch, tests ran OK, commited. > > > > Adriano Crestani > > > > On 8/3/07, Andy Grove <[EMAIL PROTECTED] > wrote: > > > > > > > > > > > > Thanks Adriano, Fuhwei, > > > > > > I've re-created the patch using the trunk code as at revision 562418 and > > > > > > attached it to the JIRA. > > > > > > I'm happy to submit the patch directly if everyone is happy with the > > > approach I'm taking on this issue. > > > > > > Thanks, > > > > > > Andy. > > > > > > -----Original Message----- > > > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On > > > Behalf Of Adriano Crestani > > > Sent: 03 August 2007 05:41 > > > To: tuscany-dev@ws.apache.org > > > Subject: Re: Patch for TUSCANY-1397 > > > > > > I've patched the sdo trunk under revision 562325 with the patch Andy > > > created. All tests ran fine, even though it failed on the tests > > > described on thread [1], but I these fails have nothing to do with Andy > > > patch, so it's ok for me ; ). Anyway, I will wait for a new created > > > patch from Andy, once Fuhwei is saying the actual patch is based on an > > > older version. > > > > > > [1] > > > http://mail-archives.apache.org/mod_mbox/ws-tuscany-dev/200708.mbox/brow > > > ser > > > > > > Regards, > > > Adriano Crestani > > > > > > On 8/2/07, Fuhwei Lwo <[EMAIL PROTECTED]> wrote: > > > > > > > > I think the patch is based on an older version of DataObjectUtil.java. > > > > > > > Can you create a new patch? Thanks. > > > > > > > > Adriano Crestani <[EMAIL PROTECTED]> wrote: I may commit it > > > > till the eod if nobody has no objection ; ) > > > > > > > > Adriano Crestani > > > > > > > > On 8/2/07, Andy Grove wrote: > > > > > > > > > > I've submitted a patch for TUSCANY-1397 and I'd like someone to > > > > > review this before I apply it since it is my first patch to the > > > > > Tuscany SDO implementation (I've only been submitting to the CTS > > > until now). > > > > > > > > > > The purpose of this patch is to implement on-demand creation of > > > > > properties in createDataObject(). > > > > > > > > > > https://issues.apache.org/jira/browse/TUSCANY-1397 > > > > > > > > > > Thanks, > > > > > > > > > > Andy. > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > -- Luciano Resende Apache Tuscany Committer http://people.apache.org/~lresende http://lresende.blogspot.com/ --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
