[ 
https://issues.apache.org/jira/browse/TUSCANY-1500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Simon Nash updated TUSCANY-1500:
--------------------------------

    Attachment: patch3

Here is patch3 for this JIRA. It enables the callback-set-callback test in the 
build and gets it working.  One small piece is still left to do for this test 
(adding a missing error check) and I will do this after we have cut the branch 
for the 0.99 release.

Here's a very brief summary of the changes in this patch.

1. Rename CallBackSetCallbackTestCaseFIXME.java to 
CallBackSetCallbackTestCase.java. (NOTE: This must be done manually before 
applying the patch, which contains an update to 
CallBackSetCallbackTestCase.java.)

2. Change the class name for the test from CallBackSetCallbackTestCaseFIXME to 
CallBackSetCallbackTestCase.

3. Change the test code where it was not using the spec APIs correctly.

4. Various runtime changes to enable the correct passing of the callback object 
on requests and checking for some error cases.  These include changing 
RequestContextImpl.getServiceReference() to return a CallableReference as 
required by the spec, as this change was needed to get the final part of the 
test to pass

The outstanding item still to be done for this test case is to add the required 
error check for invoking a service with a callback when the sender does not 
implement the callback object and there is no callback object set.  For now I 
have commented out the line in the test case that tests the diagnostic for this 
that is mandated by the spec.

I am looking at the other failing callback tests and I will post further 
patches to get them working.

> Many callback tests don't run
> -----------------------------
>
>                 Key: TUSCANY-1500
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-1500
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SCA Core Runtime
>    Affects Versions: Java-SCA-Next
>         Environment: Windows XP
>            Reporter: Simon Nash
>            Assignee: Simon Nash
>             Fix For: Java-SCA-Next
>
>         Attachments: patch1, patch2, patch3
>
>
> The following itests are currently disabled in the build.  If they are 
> enabled by changing the name of the test class from xxxTest to xxxTestCase, 
> they fail with various errors.
>   callback-api
>   callback-complex-type
>   callback-id
>   callback-set-callback
>   callback-set-conversation

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to