As we have seen so far - 1) testing the changes by unit test cases - adds more dependencies and can have licensing issues 2) and testing the changes by sample - creates sample just for a single feature and not for a set of features
>From the above 2 approaches it is verified that the change is working fine for Derby as well as MySQL (and JIRA patches will serve for history). So may be helpful to "just document feature with example cfg in user documentation" instead of going for 1) and 2). Regards, Amita On Nov 13, 2007 7:10 AM, Luciano Resende <[EMAIL PROTECTED]> wrote: > Basically, I changed the company-webapp not to create a database so I > could use the one I created with authentication required. And I didn't > use the new code, basically I used the support to configure > username/password when defining the data source. > > > > On Nov 11, 2007 11:32 PM, Amita Vadhavkar <[EMAIL PROTECTED]> wrote: > > What are the modifications you did for this in company webapp? Did you > > see that the DS.getConnection(id, pwd) signature is being used > > by DAS during this case? > > > > Regards, > > Amita > > > > > > On Nov 9, 2007 11:40 AM, Luciano Resende <[EMAIL PROTECTED]> wrote: > > > Hi Amita > > > > > > I replied to this other thread [1] with some questions. But just > > > FYI, I was able to run a slightingly modified version of > > > company-webapp using a secured derby database in TC by specifying the > > > username/password on the datasource definition. > > > > > > <Resource name="jdbc/dastest" > > > type="javax.sql.DataSource" > > > auth="Container" > > > description="Derby database for DAS Samples" > > > maxActive="100" maxIdle="30" > > > maxWait="10000" username="dastest" > > > password="dastest" > > > > > > driverClassName="org.apache.derby.jdbc.EmbeddedDriver" > > > > > > url="jdbc:derby:D:/Opensource-Servers/apache-tomcat-5.5.20/Databases/dastest;create=true"/> > > > > > > > > > [1] http://www.mail-archive.com/[email protected]/msg25244.html > > > > > > > > > On Nov 6, 2007 8:33 PM, Amita Vadhavkar <[EMAIL PROTECTED]> wrote: > > > > 1> readmes commit - I will wait and make it along with any other > > > > changes in JIRA-1698 as we are still deciding which sample to use to > > > > demo the feature of > > > > JIRA-1698 > > > > > > > > 2> There are 3 test cases in ConnectionTests, please see if you find > > > > some other cases that can be included. > > > > > > > > 3> Using jboss jars - as these were available on mvn repo, I missed > > > > the point of license, if license is the issue, then these can not be > > > > used. > > > > > > > > TC has > > > > (default)BasicDataSource - which does not support getConnection(id, pwd) > > > > and > > > > PerUserPoolDataSource, SharedPoolDataSource - which support > > > > getConnection(id, pwd) > > > > > > > > When trying to configure PerUserPoolDataSource, SharedPoolDataSource > > > > with TC 6.0.14, was getting different errors, will see if can get this > > > > working. > > > > > > > > I am not doing any commits related to this JIRA, till 3> or some other > > > > sample is formed, so all changes will go together. > > > > > > > > Regards, > > > > Amita > > > > > > > > > > > > On Nov 6, 2007 11:06 PM, Luciano Resende <[EMAIL PROTECTED]> wrote: > > > > > Comments inline : > > > > > > > > > > On 11/6/07, Amita Vadhavkar <[EMAIL PROTECTED]> wrote: > > > > > > changes done - > > > > > > > > > > > > 1) cleaned readme files using eclipse IDE html editor - samples, > > > > > > dbconfig > > > > > Good, Thanks, please committ this, you don't have to wait anymore :) > > > > > > > > > > > 2) replaced MySQL with Derby > > > > > Just want to make sure you have all the functionality you need in > > > > > Derby... > > > > > > > > > > > 3) replaced sun provided JNDI jars with jboss jar - because - these > > > > > > are > > > > > > available in mvn repos and only 3 are required in the build path > > > > > > (jboss-common 3.2.3, jnp-client 4.0.2 and jnpserver 3.2.3 - total > > > > > > 350 KB) > > > > > > > > > > I downloaded the jars, but couldn't find any license files there. > > > > > Also, JBOSS stuff tend to be LGPL and that is not ASF Friendly, so > > > > > could you please point me to the proper license for these files ? > > > > > > > > > > > > > > > > 4) added more test cases in ConnectionTests.java and removed > > > > > > sample-dataSource > > > > > > 5) patch attached to JIRA-1698 > > > > > > > > > > > > Please see if there are any problems in the above, else I will > > > > > > commit the > > > > > > patch. > > > > > > The bin size increase due to jboss jars is 350 KB and so it may be > > > > > > OK to > > > > > > make it > > > > > > as test cases instead of sample. > > > > > > > > > > > > > > > > > > > > > Well, in summary, it's lots of dependencies issues to demonstrate we > > > > > now support authentication when retrieving the datasource > > > > > connection... and based on the dependencies being dragged to DAS > > > > > distro... I'm now inclined to have just a sample, or simpler, just > > > > > document in the User Guide. > > > > > > > > > > BTW, I'll play with this over the weekend and try to make this working > > > > > in TC with Companyweb... Maybe this is a simpler solution :) > > > > > > > > > > > > > > > > Regards, > > > > > > Amita > > > > > > > > > > > > On 11/5/07, Amita Vadhavkar <[EMAIL PROTECTED]> wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 11/5/07, Luciano Resende <[EMAIL PROTECTED]> wrote: > > > > > > > > > > > > > > > > I was trying to run the new DAS sample (dataSource) and I looks > > > > > > > > like > > > > > > > > it requires MySQL in order to run the sample, this might not be > > > > > > > > the > > > > > > > > best default configuration to require, as it requires lots of > > > > > > > > steps in > > > > > > > > order to just try the sample ( e.g install MySQL), and it also > > > > > > > > makes it > > > > > > > > difficult to test the sample during build. I'd like to suggest > > > > > > > > two > > > > > > > > things for our DAS Sample applications : > > > > > > > > > > > > > > > > - Use Derby as the default database in a sample application > > > > > > > > > > > > > > > > > > > > > Agree, done changes for this > > > > > > > > > > > > > > - Have a simple unit test to quickly check if the sample is > > > > > > > working > > > > > > > > (use htmlUnit for webapp) > > > > > > > > > > > > > > > > > > > > > The jira has test cases for case which does not require external > > > > > > > JNDI. > > > > > > > Which JNDI jar is available > > > > > > > as part of maven repo? I could not spot one and used sun's jars. > > > > > > > As these > > > > > > > can not get downloaded > > > > > > > thru mvn build and need to be placed manually in the classpath, > > > > > > > used > > > > > > > sample instead of junit for > > > > > > > testcase which requires JNDI. But if there is a maven repo based > > > > > > > jar > > > > > > > providing JNDI, the sample > > > > > > > can be removed and instead junit cases can be added. Tried > > > > > > > RootContext > > > > > > > from Geronimo but it is > > > > > > > read only. > > > > > > > > > > > > > > Also, I was wondering what we should use for demonstrating a > > > > > > > specific > > > > > > > > feature... I guess we might not need a new sample for every new > > > > > > > > feature, this might increase the complexity of developing a new > > > > > > > > feature, I guess a test case might be good enough.... and a > > > > > > > > sample > > > > > > > > would be used more to demonstrate a bigger scenario or a how a > > > > > > > > set of > > > > > > > > features work together... > > > > > > > > > > > > > > > > Thoughts ? > > > > > > > > > > > > > > > > -- > > > > > > > > Luciano Resende > > > > > > > > Apache Tuscany Committer > > > > > > > > http://people.apache.org/~lresende<http://people.apache.org/%7Elresende> > > > > > > > > http://lresende.blogspot.com/ > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > > > > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > Luciano Resende > > > > > Apache Tuscany Committer > > > > > http://people.apache.org/~lresende > > > > > http://lresende.blogspot.com/ > > > > > > > > > > --------------------------------------------------------------------- > > > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > > > > > > > > > > > -- > > > Luciano Resende > > > Apache Tuscany Committer > > > http://people.apache.org/~lresende > > > http://lresende.blogspot.com/ > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > -- > Luciano Resende > Apache Tuscany Committer > http://people.apache.org/~lresende > http://lresende.blogspot.com/ > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
