On Nov 20, 2007 3:59 PM, Jean-Sebastien Delfino <[EMAIL PROTECTED]> wrote:
> Are you sure that this is the right semantics? Can you help me > understand why we need to change the naming of the service if there's a > a callback? > > Thanks. > > > [EMAIL PROTECTED] wrote: > > Author: slaws > > Date: Tue Nov 20 06:35:45 2007 > > New Revision: 596692 > > > > URL: http://svn.apache.org/viewvc?rev=596692&view=rev > > Log: > > TUSCANY-1914 > > Construct URLs as ComponentName/ServiceName if callbacks have been added > causing the number of services to be greater than 1 > > > > Modified: > > > incubator/tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/CompositeConfigurationBuilderImpl.java > > > > Modified: > incubator/tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/CompositeConfigurationBuilderImpl.java > > URL: > http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/CompositeConfigurationBuilderImpl.java?rev=596692&r1=596691&r2=596692&view=diff > > > ============================================================================== > > --- > incubator/tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/CompositeConfigurationBuilderImpl.java > (original) > > +++ > incubator/tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/CompositeConfigurationBuilderImpl.java > Tue Nov 20 06:35:45 2007 > > @@ -280,7 +280,8 @@ > > > > String bindingURI; > > if (binding.getURI() == null) { > > - if (componentServices.size() > 1) { > > + //if (componentServices.size() > 1) { > > + if (component.getServices().size() > 1) { > > // Binding URI defaults to component URI / > binding name > > bindingURI = String.valueOf(binding.getName > ()); > > bindingURI = URI.create(component.getURI() > + '/').resolve(bindingURI).toString(); > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > -- > Jean-Sebastien > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > Maybe I'm getting the wrong end of the stick here. When a callback is encountered on a component reference a new callback service is now created to represent the endpoint of the callback [createCallbackService(Component, ComponentReference) in the CompositeConfigurationBuilder]. I believe the intention is to treat these new services in the same way as any other service that the component may be providing. The URL of these services must then follow the same rules as the other services that the component exposes. In particular if the component has more than one service then more fidelity is required in each service URL in order to differentiate between them. The change here is intended to include the newly created callback services when considering how many services a component has. Regards Simon
