On Jan 2, 2008 3:44 PM, Simon Nash <[EMAIL PROTECTED]> wrote: > I just committed r608125 which changes the serialization format of the > CallableReference and ServiceReference signature types from base64 binary > to XML strings (see TUSCANY-1943). > > There are some method signatures that pass around service references > using the Externalizable type. I did not change these in r608125. > For consistency I would like to change these signatures to use the > ServiceReference type so that they will be serialized to XML instead > of to base64 binary. Does anyone object to this change? > > I have identified the following signatures that would be affected: > > > sca\modules\domain\src\main\java\org\apache\tuscany\sca\domain\SCADomainEventService.java > registerNode() > > > sca\modules\domain\src\main\java\org\apache\tuscany\sca\domain\model\NodeModel.java > getNodeManagerReference() > setNodeManagerReference() > > > sca\modules\domain-impl\src\main\java\org\apache\tuscany\sca\domain\impl\SCADomainImpl.java > registerNode() > > > sca\modules\domain-impl\src\main\java\org\apache\tuscany\sca\domain\management\impl\SCADomainManagerServiceImpl.java > registerNode() > > > sca\modules\domain-impl\src\main\java\org\apache\tuscany\sca\domain\model\impl\NodeModelImpl.java > getNodeManagerReference() > setNodeManagerReference() > > > sca\modules\node-impl\src\main\java\org\apache\tuscany\sca\node\impl\SCADomainEventServiceProxyImpl.java > registerNode() > > > sca\modules\binding-sca-axis2\src\test\java\org\apache\tuscany\sca\binding\sca\axis2\TestDomain.java > registerNode() > > Code updates would also be needed to the following files: > > > sca\modules\domain-impl\src\test\java\org\apache\tuscany\sca\domain\impl\DomainImplTestCase.java > > > sca\modules\domain-impl\src\test\java\org\apache\tuscany\sca\domain\impl\TestCallableReferenceImpl.java > > Simon > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > Hi Simon
I have no objections. Would be great if you could do the fixes. Regards Simon
