On 09/04/2008, Luciano Resende <[EMAIL PROTECTED]> wrote: > Please review and vote on the 1.2 release artifacts of Tuscany SCA for Java. > > The artifacts are available for review at: > http://people.apache.org/~lresende/tuscany/sca-1.2-RC3a/ >
L&N look O; digests and sigs OK. Extraneous files: ----------------------- Do the following really belong in the source archive? They are not in SVN. itest/transaction/derbydb/ modules/osgi-runtime/.felix/ Various automatically generated test cases (e.g. InteropDatabindingTestCase.java) === Odd file: ----------- OSGiRuntimeTestCase.java in modules\implementation-osgi\src\test\java\org\apache\tuscany\sca\implementation\osgi\runtime is completely empty. Minor points: BUILDING mentions using Java 1.5.0_06 and Maven 2.0.5. Both of these have been superseded; perhaps the text should mention that later versions are OK as well (unless they are not; the text is not clear about this). Manifests -------------- It would be nice to have the java compiler source and target versions in all the binary jars. It would be nice to have the Specification and Implementation headers in all the manifests, as is done inrg.apache.tuscany.sca.core-1.2-incubating.jar > > This includes the signed binary and source distributions, the RAT report, > and the Maven staging repository. > > The eclipse updatesite for the Tuscany Eclipse plugins is available at: > http://people.apache.org/~lresende/tuscany/sca-1.2-RC3a/updatesite/ > -1: org.apache.tuscany.sca.feature-1.2-incubating.jar and org.apache.tuscany.sca.core-1.2-incubating.jar NOTICE says: ${pom.name} Copyright (c) 2005 - 2008 The Apache Software Foundation The first line is wrong in both. -1: Also, the top-level NOTICE file in the archive does not have the same attributions as in the org.apache.tuscany.sca.core-1.2-incubating.jar. The overall NOTICE file should contain all subordinate attributions. > The release tag is available at : > http://svn.apache.org/repos/asf/incubator/tuscany/tags/java/sca/1.2-RC3a/ > > > Looks OK to me, here is my +1. > > > -- > Luciano Resende > Apache Tuscany Committer > http://people.apache.org/~lresende > http://lresende.blogspot.com/ > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
