On Thu, Apr 17, 2008 at 9:44 AM, Mark Combellack <[EMAIL PROTECTED]> wrote:
> I'm looking to fix this issue now > > I'm testing a fix and about to commit. > > Mark > > > > -----Original Message----- > > From: Simon Laws [mailto:[EMAIL PROTECTED] > > Sent: 17 April 2008 09:42 > > To: tuscany-dev@ws.apache.org > > Subject: Re: svn commit: r648763 - > > > /incubator/tuscany/java/sca/modules/databinding/src/main/java/org/apache/t > > uscany/sca/databinding/impl/DirectedGraph.java > > > > On Wed, Apr 16, 2008 at 6:31 PM, <[EMAIL PROTECTED]> wrote: > > > > > Author: rfeng > > > Date: Wed Apr 16 10:31:00 2008 > > > New Revision: 648763 > > > > > > URL: http://svn.apache.org/viewvc?rev=648763&view=rev > > > Log: > > > Fix for TUSCANY-2069 > > > > > > Modified: > > > > > > > > > incubator/tuscany/java/sca/modules/databinding/src/main/java/org/apache/tu > > scany/sca/databinding/impl/DirectedGraph.java > > > > > > Modified: > > > > > > incubator/tuscany/java/sca/modules/databinding/src/main/java/org/apache/tu > > scany/sca/databinding/impl/DirectedGraph.java > > > URL: > > > > > > http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/databindin > > > g/src/main/java/org/apache/tuscany/sca/databinding/impl/DirectedGraph.java > > ?rev=648763&r1=648762&r2=648763&view=diff > > > > > > > > > ========================================================================== > > ==== > > > --- > > > > > > incubator/tuscany/java/sca/modules/databinding/src/main/java/org/apache/tu > > scany/sca/databinding/impl/DirectedGraph.java > > > (original) > > > +++ > > > > > > incubator/tuscany/java/sca/modules/databinding/src/main/java/org/apache/tu > > scany/sca/databinding/impl/DirectedGraph.java > > > Wed Apr 16 10:31:00 2008 > > > @@ -26,6 +26,7 @@ > > > import java.util.List; > > > import java.util.Map; > > > import java.util.Set; > > > +import java.util.concurrent.ConcurrentHashMap; > > > > > > /** > > > * Directed, weighted graph > > > @@ -72,7 +73,8 @@ > > > > > > } > > > > > > - private final Map<VertexPair, Path> paths = new > HashMap<VertexPair, > > > Path>(); > > > + // Fix for TUSCANY-2069, making the map concurrent > > > + private final Map<VertexPair, Path> paths = new > > > ConcurrentHashMap<VertexPair, Path>(); > > > > > > /** > > > * Vertex of a graph > > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > Hi > > > > Don't know if anyone else is seeing this but this change is causing a > NPE > > in > > DirectedGraphTestCase for me. Am looking at it now. > > > > Simon > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > Ok , great. Thanks Mark. I'll hold back then. Let me know if you need any help. Simon