[
https://issues.apache.org/jira/browse/TUSCANY-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597473#action_12597473
]
Simon Laws commented on TUSCANY-2277:
-------------------------------------
Hi Ram
Was just trying to apply these patches and am having a few problems. What tool
did you use to generate them? I'm guessing Msftedit from the header. Can you
regenerate them using a diff tool. Let me know if you need some help.
The issues I'm having are....
- has a strange Msft header (I can libe with this as I can remove it nmanually)
- the file dirs are absolute (I can live with this as I can go in and edit)
- there are some escaped charaters in there, e.g. \tab, \par, \{, \} which mess
it up. (I can't get round this as fixing manually messes up the formatting and
the patch tool can't then match the patch against the original code)
Thanks
Simon
> Standardization of registering msg with monitor
> -----------------------------------------------
>
> Key: TUSCANY-2277
> URL: https://issues.apache.org/jira/browse/TUSCANY-2277
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA Assembly Model
> Affects Versions: Java-SCA-Next
> Environment: Windows XP
> Reporter: Ramkumar Ramalingam
> Assignee: Simon Laws
> Fix For: Java-SCA-Next
>
> Attachments: TUSCANY-2277-Part1.patch, TUSCANY-2277-Part2.patch,
> TUSCANY-2277-Part3.patch
>
>
> Lokking at the monitors that are being hooked up with different parts of the
> code, found that we have some inconsistency interms of raising warning &
> errors. In some places we throw exceptions and in other places we raise a
> warning.
>
> Here are some examples for the inconsistency.......
>
> BaseConfigurationBuilderImpl.java
> Here we raise only a warning for URISyntaxException, should we not throw an
> exception too?
>
> BaseWireBuilderImpl.java
> Here we throw exceptions for IncompatibleInterfaceContractException, don't
> you think we also need to register this message in our monitor?
> In the same class, we raise a warning message for the PolicyRelated
> Exceptions, should we also throw an exception here?
>
> CompositeProcessor.java
> There are instances where we throw new ContributionReadException, i believe
> registering this msg with a monitor is also required as this is caused by
> incorrect user input.
> From Simon's comments on how we can go ahead with handling such instance, we
> will fix the issue as discussed....
> http://www.mail-archive.com/[email protected]/msg30994.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
