Nice! That's what I've been expecting. Thanks. Your one string command is tiny and complete. And elegant. Final desicion? Or it could be something better and more professional? So we have removed regexps and everything is fine now. Yes?
On Mon, 01 Aug 2011 02:37:09 +1000 Steven D'Aprano <st...@pearwood.info> wrote > Sergey wrote: > > Gotcha! > > http://pymon.googlecode.com/svn/tags/pymon-0.2/Internet/rsync.py > > 231-239 strings > > > > ## code ## > > > > def convertPath(path): > > # Convert windows, mac path to unix version. > > separator = os.path.normpath("/") > > if separator != "/": > > path = re.sub(re.escape(separator), "/", path) > > The above code is buggy. It doesn't work as expected on a classic Mac. > Hint: import macpath; print macpath.normpath('/') > > Besides, there is no need to use the 20 lb sledgehammer of regular > expressions to crack the tiny little peanut of replacing a simple > character with another simple character. > > The above function is much more sensibly written as: > > def convertPath(path): > separator = os.path.sep > if sep != '/': > path = path.replace(os.path.sep, '/') > return path > > Or even more simply: > > return path.replace(os.path.sep, '/') > > (although that may do a small amount of unnecessary work on Unix systems). > > > > > -- > Steven > > _______________________________________________ > Tutor maillist - Tutor@python.org > To unsubscribe or change subscription options: > http://mail.python.org/mailman/listinfo/tutor ____________________________________________________________ South Africas premier free email service - www.webmail.co.za For super low premiums, click here http://www.dialdirect.co.za/?vdn=15828 _______________________________________________ Tutor maillist - Tutor@python.org To unsubscribe or change subscription options: http://mail.python.org/mailman/listinfo/tutor
