>However, the subprocess call above uses a list for the command, and that form >DOES NOT pass anything to the shell. The >command gets executed directly. And >therefore no spaces need escaping at all.
That makes more sense to me now. In terms of the code review, I found that stackexchange has a code review site, in case anyone else is curious: https://codereview.stackexchange.com It would be hard to post a sscc example since the parts I am curious about reference other class variables that would be unclear out of context, I think. Much appreciated... On Fri, Aug 1, 2014 at 4:38 AM, Ben Finney <ben+pyt...@benfinney.id.au> wrote: > Peter Otten <__pete...@web.de> writes: > >> C Smith wrote: >> >> > Nice, these are useful tools. I have been building something with >> > just basic stuff and avoiding learning any libraries. If I wanted to >> > get some insight on a larger program that is about 1000 lines, would >> > that be doable here? >> >> In general we prefer concrete questions and smaller chunks of code. >> With 1000 lines you get fewer people to even take a look. > > Right. When attrmpting to learn, keep the examples simple. This will > make it easier to focus on the essential points, and also minimise whole > categories of error. > > To get feedback on some code, make it a Short, Self-Contained, > Compilable Example <URL:http://sscce.org/>. This means we will be able > to read the code quickly, run it ourselves, and better see what its > purpose is. > >> You might still try and post a link to the code together with a few >> questions here... > > Not really advised. If the code is too long to discuss in context here, > much of the point is lost; we prefer discussions to have the code inline > so the public archives contain the code too. That's an important reason > to keep it short and self-contained. > > -- > \ “I bought some batteries, but they weren't included; so I had | > `\ to buy them again.” —Steven Wright | > _o__) | > Ben Finney > > _______________________________________________ > Tutor maillist - Tutor@python.org > To unsubscribe or change subscription options: > https://mail.python.org/mailman/listinfo/tutor _______________________________________________ Tutor maillist - Tutor@python.org To unsubscribe or change subscription options: https://mail.python.org/mailman/listinfo/tutor
