Daniel Phillips <[EMAIL PROTECTED]> writes: >> >> Good catch. A better way to fix this is using gcc attribute packed, >> >> which is done by the Tux3 macro PACKED: >> > >> > But, I think the result of it is aliment fault on some archs. >> >> if we accessed ->ibase. Or we should use get_unaligned()? > > I think we do want to pad it just as you have done. We do need to get > unaligned in other code, the inode attributes specifically, and make > sure that always works. We also do an endian conversion every time we > do this, so it is always going to be wrapped in a macro. But I am not > sure that the endian macros can handle unaligned accesses on all > architectures.
I see. BTW, Linux has macros for it - get_unaligned_be*/_le*. -- OGAWA Hirofumi <[EMAIL PROTECTED]> _______________________________________________ Tux3 mailing list [email protected] http://tux3.org/cgi-bin/mailman/listinfo/tux3
