On Monday 17 November 2008 00:13, OGAWA Hirofumi wrote:
> Hi,
>
> I have some patches for tux3. With those, tux3 will be geting closer to
> kernel more. Well, kernel can't compile with those though, many errors
> were reduced.
>
> static-http://userweb.kernel.org/~hirofumi/tux3/
>
> Please review it.
Good and necessary changes. Minor things:
"Move some functions under #ifdef __KERNEL__"
- Some of these moves seem to be to avoid "function not used" warnings.
It would be better just to disable thR warning right now. We are not
interested in which functions are unused at this stage of kernel
porting.
"Wrap/rename buffer stuff to get closer to kernel"
- buffer_head is a structure name I have always disliked because of
being inconsistent with "struct page" and "struct inode" etc, and it
is needlessly verbose. Instead lets do #define buffer_head buffer in
kernel/tux3.h.
Regards,
Daniel
_______________________________________________
Tux3 mailing list
[email protected]
http://tux3.org/cgi-bin/mailman/listinfo/tux3
