On Wednesday 07 January 2009 12:30, Daniel Phillips wrote: > On Wednesday 07 January 2009 07:25, OGAWA Hirofumi wrote: > > Daniel Phillips <[email protected]> writes: > > > > >> > Your patch breaks the user space compile because your macro definitions > > >> > appear outside the __KERNEL__ macro. Could you try this version? > > >> > > >> Yes, It is OK, and better than my version. > > > > > > OK, committed with credit to you. > > > > COW credential was added after 2.6.28. And we shouldn't add needless #ifdef. > > [BTW, if we really want to do this, we should add compat layer like > > compat.h of external network drivers.] > > > > Thanks. > > Gah, I checked the exact version of the change, then off-by-oned the > #if.
Ah, no, I did it correctly. The macro showed up in 2.6.27, apparently to ease the transition: http://lxr.linux.no/linux+v2.6.27/include/linux/cred.h#L28 So my commit didn't break anything. Your improvement is also fine. I would like to keep the #if on VERSION. Regards, Daniel _______________________________________________ Tux3 mailing list [email protected] http://mailman.tux3.org/cgi-bin/mailman/listinfo/tux3
