On Mar 9, 2018, at 4:03 AM, Ilya Skriblovsky <ilyaskriblov...@gmail.com> wrote: > > Just wanted to make sure, did I all what I should do for putting this ticket > into review: https://twistedmatrix.com/trac/ticket/9374 > <https://twistedmatrix.com/trac/ticket/9374> ? > Should I just wait for maintainers to review it?
You've done all the right things. :) Twisted maintainers go through the list at https://twisted.reviews <https://twisted.reviews/> and review things, and you can indeed see that your change is on that list. Unfortunately, as you can see, there's quite a backlog. Personally I have been quite busy with a new child and a new startup, so (as previously discussed on this very mailing list) I haven't been doing much in the way of code review myself recently. Even what little open source time I have needs to be focused elsewhere at the moment. The best thing you can do to accelerate your own change getting reviewed is to code review others' changes, so that when a reviewer arrives to stochastically select something to review it is more likely that they'll select your thing instead of one of the other things :-). The second best thing you can do is to donate a lot of money using the form on the front page of the web site: https://twistedmatrix.com/trac/#DonatetoTwisted <https://twistedmatrix.com/trac/#DonatetoTwisted>, which, at some point, will allow us to re-start the Twisted fellowship program http://labs.twistedmatrix.com/2015/06/twisted-fellowship-2015-call-for.html <http://labs.twistedmatrix.com/2015/06/twisted-fellowship-2015-call-for.html> and have someone actually keep the review queue clear as their actual paid responsibility :). -g
_______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
