Dear Tom, thanks for helping me out. I really appreciate it.
Best regards, Thomas -----Original Message----- From: Twisted-Python [mailto:twisted-python-boun...@twistedmatrix.com] On Behalf Of Tom Most Sent: Monday, May 27, 2019 6:04 AM To: twisted-python@twistedmatrix.com Subject: Re: [Twisted-Python] Twisted Agent Python 2 ->3 Porting Pitfalls I filed https://twistedmatrix.com/trac/ticket/9643 and submitted a PR: https://github.com/twisted/twisted/pull/1146 ---Tom On Thu, May 23, 2019, at 11:50 PM, Glyph wrote: > I definitely agree with this! > > -g > > > On May 23, 2019, at 9:08 PM, Tom Most <t...@freecog.net> wrote: > > > > This looks like a straightforward bug to me. I don't see any reason we > > can't change the implementation to either raise TypeError immediately or > > accept a string, since any code that passes a string doesn't work right > > now. Would you file a bug at https://twistedmatrix.com/trac/newticket? > > > > ---Tom > > > > -- > > Tom Most > > t...@freecog.net > > > > On Mon, May 20, 2019, at 12:22 AM, Thomas Westfeld wrote: > >> Dear all, > >> > >> I just migrated some quite basic twisted code from Python 2.7 to Python > >> 3. Everything worked quite nicely, the main issue was the correct > >> handling of strings vs. bytes. > >> > >> There was a mean error I made when using the Twisted Agent http client: > >> I specified the method as a Unicode string, instead of using > >> Agent.request(b'GET',b'http://whatever.com'). The mean thing is that > >> the code does not produce any error. It connects to the server via TCP > >> but then stops. > >> > >> It is given correctly in the examples of the docs and also in the > >> source code, but wouldn't it make things easier to make a type check in > >> the request method if the method parameter is of type Unicode and raise > >> an error? > >> > >> Best regards, > >> Thomas Westfeld > >> _______________________________________________ > >> Twisted-Python mailing list > >> Twisted-Python@twistedmatrix.com > >> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python > >> > > > > _______________________________________________ > > Twisted-Python mailing list > > Twisted-Python@twistedmatrix.com > > https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python > > _______________________________________________ > Twisted-Python mailing list > Twisted-Python@twistedmatrix.com > https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python > _______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ Twisted-Python mailing list Twisted-Python@twistedmatrix.com https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
