On Thu, Jan 12, 2006 at 05:06:12PM +0100, Valentino Volonghi wrote: > Cool, the patch looks good. I'm going to apply it as soon as there are > unittests. Some ideas for unittests is to have a counter on the page and check > that it never updates while the pages are cached and similar things.
The ideal unittest would depend on the timings too. Are unittest allowed to depend on the timigs? However writing the unittest is going to be more difficult than writing the feature ;) > I suggest also adding a ticket to trac for your patch. Ok. BTW, in the meantime I did a minor cleanup, the first deferred in the list isn't needed, it can be replaced by Null, that saves some bytes at runtime (nothing measurable but anyway). Thanks! _______________________________________________ Twisted-web mailing list [email protected] http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-web
