On 26/02/2022 1:00 am, Jean-Paul Calderone wrote:
On Thu, Feb 24, 2022 at 5:22 PM Ian Haywood <[email protected]>
From just a quick skim of the part of the implementation dealing with
`--until-failure` behavior, I guess that I would try to refactor so
that `trial -u -jN` and `trial -u` share their implementation of this
functionality instead of each implementing it separately. If `trial
-u` already has tests and you can get rid of the dedicated `trial -u
-jN` code that's a big step towards the testing goal - and always
better to delete unnecessary code than to keep it, fix it, and have to
write and maintain tests for it.
However, like I said, I only gave the code a brief skim. For all I
know, there is some major hurdle in the way of such a refactoring.
it appears trial is almost two programs in one: a distributed and a
non-distributed version. Obviously -jN selects which version you get and
the decision is made very early: in scripts/trial
So IMHO single implementation of -u isn't possible.
I have a minimalist solution to #10312
https://github.com/twisted/twisted/pull/1702
Ian
_______________________________________________
Twisted mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/twisted.python.org/
Message archived at
https://mail.python.org/archives/list/[email protected]/message/QILWMQYVF2J7W34YK6W7BPVIOKZCQMNM/
Code of Conduct: https://twisted.org/conduct
