On Mon, Apr 11, 2022 at 6:31 PM Glyph <[email protected]> wrote:
> > On Apr 11, 2022, at 11:29 AM, Jean-Paul Calderone < > [email protected]> wrote: > > On Wed, Apr 6, 2022 at 9:21 PM Jean-Paul Calderone < > [email protected]> wrote: > >> Hello, >> >> I've just written up an idea for an approach to getting many parts of >> Twisted and Twisted-based applications onto coroutines (ie `async def`). >> >> Details are given on https://twistedmatrix.com/trac/ticket/10327 >> >> The change involves the potential for some incompatibilities - though as >> I described on the ticket, I think these are likely to be very rare in >> practice and worth imposing for the resulting payoff. >> >> This thread represents the start of the process for making incompatible >> changes to Twisted as described at >> https://twistedmatrix.com/documents/current/core/development/policy/compatibility-policy.html#procedure-for-exceptions-to-this-policy >> > > Thanks to everyone who supplied feedback. Since it seemed positive, I've > taken the next step in the process - > https://github.com/twisted/twisted/pull/1718 is a PR that implements the > proposed change in behavior. > > According to the compatibility policy, this should be accepted if three > committers approve and there are no objections for one week. > > I'm not in any huge rush so I don't imagine trying to merge this in > exactly 7 days from this email (in fact, I'm on vacation all next week...) > > Please have a look and let me know if you spot any problems. > > > It’s not a huge problem, but I reviewed on github and my only real > feedback is “I think we should use a regular `isinstance`.” But I’ll leave > it to you as the author of this change to make the call. > > Hopefully another committer or two can have a look soon. > Thank you to the three reviewers so far - glyph, twm, and adiroiban. I believe that the PR is now in its final form and has been approved by three Twisted committers. So at this point, the change will land. As I mentioned previously, I probably won't land it Monday but I may towards the end of the week - unless there is further feedback before then. Jean-Paul
_______________________________________________ Twisted mailing list -- [email protected] To unsubscribe send an email to [email protected] https://mail.python.org/mailman3/lists/twisted.python.org/ Message archived at https://mail.python.org/archives/list/[email protected]/message/UX5A4AD4T4NVCYM3QDGJMMJYP3XOS6O4/ Code of Conduct: https://twisted.org/conduct
